Keep starter links under Astro base - #112
Closed
sansynx wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Appreciate the PR, but this has been also resolved on main as part of the broader server-side rendering and API-reference work in #114. |
Contributor
Author
|
Got it, thanks for the heads up. I'll leave this one closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the sub-path links and assets described in #105:
baseThe root
indexroute noted in the issue is handled separately in #111.Verification
node --import tsx --test test/subpath-template-contract.test.ts test/url.test.tspnpm --filter nimbus-docs typecheckpnpm --filter nimbus-docs buildpnpm --filter nimbus-starter-source typecheckpnpm --filter nimbus-starter-source build/spike; favicon, Shiki CSS, sidebar, breadcrumbs, header, and navigation all resolved under that path