Skip to content

feat: use native Satteri admonitions - #139

Merged
MohamedH1998 merged 4 commits into
mainfrom
feat/native-satteri-admonitions-v2
Sep 12, 2026
Merged

feat: use native Satteri admonitions#139
MohamedH1998 merged 4 commits into
mainfrom
feat/native-satteri-admonitions-v2

Conversation

@MohamedH1998

Copy link
Copy Markdown
Collaborator

Summary

  • replace source-level admonition rewriting with a scoped native Satteri AST plugin
  • preserve plain titles, aliases, nested content, code examples, and per-file opt-outs
  • require compatible explicit processors or admonitions: false
  • align native APIs with Satteri 0.10 while isolating source-position parsing on an explicit 0.9 alias
  • add upgrade guidance for explicit processors and admonitions in .md files

Validation

  • pnpm --filter nimbus-docs test (1,652 passed, 1 skipped)
  • focused native/adapter regressions (109 passed)
  • pnpm --filter nimbus-docs typecheck
  • pnpm lint
  • BREAKING_CHANGE=1 pnpm upgrades:check
  • pnpm api-reference:check
  • pnpm templates:check
  • clean final review

Stacked on #138. Split from and intended to replace the native-admonition portion of #131. The Workers registry feasibility path remains externally blocked by a Cloudflare registry 401.

Base automatically changed from fix/authored-link-content-integrity to main September 12, 2026 13:18
@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 12, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 12, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 12, 2026

Copy link
Copy Markdown
pnpm add https://pkg.pr.new/@cloudflare/create-nimbus-docs@139
pnpm add https://pkg.pr.new/@cloudflare/nimbus-docs@139

commit: 5244e11

@MohamedH1998 MohamedH1998 added the pr preview Publish a pkg.pr.new preview for this PR label Sep 12, 2026
@github-actions github-actions Bot removed the pr preview Publish a pkg.pr.new preview for this PR label Sep 12, 2026
@MohamedH1998
MohamedH1998 marked this pull request as ready for review September 12, 2026 22:31
@MohamedH1998
MohamedH1998 merged commit 5a65392 into main Sep 12, 2026
22 checks passed
@MohamedH1998
MohamedH1998 deleted the feat/native-satteri-admonitions-v2 branch September 12, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant