Merge upstream changes

merge upstream

Author: ruifigueira

.github/actions/run-test/action.yml

@@ -41,9 +41,6 @@ runs:
         npm ci
         echo "::endgroup::"
       shell: bash
-      env:
-        DEBUG: pw:install
-        PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
     - run: |
         echo "::group::npm run build"
         npm run build

.github/workflows/cherry_pick_into_release_branch.yml

@@ -59,7 +59,7 @@ jobs:
         echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_OUTPUT
         git checkout -b "$BRANCH_NAME"
         git push origin $BRANCH_NAME
-    - uses: actions/create-github-app-token@v1
+    - uses: actions/create-github-app-token@v2
       id: app-token
       with:
         app-id: ${{ vars.PLAYWRIGHT_APP_ID }}

.github/workflows/create_test_report.yml

@@ -20,8 +20,6 @@ jobs:
         node-version: 18
     - run: npm ci
       env:
-        DEBUG: pw:install
-        PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
         ELECTRON_SKIP_BINARY_DOWNLOAD: 1
     - run: npm run build
 

.github/workflows/infra.yml

@@ -24,8 +24,7 @@ jobs:
         node-version: 18
     - run: npm ci
     - run: npm run build
-    - run: npx playwright install-deps
-    - run: npx playwright install
+    - run: npx playwright install --with-deps
     - run: npm run lint
     - name: Verify clean tree
       run: |

.github/workflows/merge.config.ts

@@ -1,4 +1,4 @@
 export default {
   testDir: '../../tests',
-  reporter: [[require.resolve('../../packages/playwright-dashboard/lib/ghaMarkdownReporterg')], ['html']]
+  reporter: [[require.resolve('../../packages/playwright-dashboard/lib/ghaMarkdownReporter')], ['html']]
 };

.github/workflows/pr_check_client_side_changes.yml

@@ -16,7 +16,7 @@ jobs:
     if: github.repository == 'microsoft/playwright'
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/create-github-app-token@v1
+      - uses: actions/create-github-app-token@v2
         id: app-token
         with:
           app-id: ${{ vars.PLAYWRIGHT_APP_ID }}
@@ -46,7 +46,7 @@ jobs:
             const title = '[Ports]: Backport client side changes for ' + currentPlaywrightVersion;
             for (const repo of ['playwright-python', 'playwright-java', 'playwright-dotnet']) {
               const { data: issuesData } = await github.rest.search.issuesAndPullRequests({
-                q: `is:issue is:open repo:microsoft/${repo} in:title "${title}" author:playwrightmachine`
+                q: `is:issue is:open repo:microsoft/${repo} in:title "${title}"`
               })
               let issueNumber = null;
               let issueBody = '';

.github/workflows/publish_canary.yml

@@ -28,7 +28,6 @@ jobs:
         registry-url: 'https://registry.npmjs.org'
     - run: npm ci
     - run: npm run build
-    - run: npx playwright install-deps
     - name: "@next: publish with commit timestamp (triggered manually)"
       if: contains(github.ref, 'main') && github.event_name == 'workflow_dispatch'
       run: |
@@ -72,7 +71,7 @@ jobs:
     - uses: actions/setup-node@v4
       with:
         node-version: 18
-    - uses: actions/create-github-app-token@v1
+    - uses: actions/create-github-app-token@v2
       id: app-token
       with:
         app-id: ${{ vars.PLAYWRIGHT_APP_ID }}

.github/workflows/publish_release_docker.yml

@@ -29,7 +29,6 @@ jobs:
         platforms: arm64
     - run: npm ci
     - run: npm run build
-    - run: npx playwright install-deps
     - name: Azure Login
       uses: azure/login@v2
       with:

.github/workflows/publish_release_driver.yml

@@ -24,7 +24,6 @@ jobs:
         registry-url: 'https://registry.npmjs.org'
     - run: npm ci
     - run: npm run build
-    - run: npx playwright install-deps
     - run: utils/build/build-playwright-driver.sh
     - name: Azure Login
       uses: azure/login@v2

.github/workflows/publish_release_npm.yml

@@ -23,7 +23,6 @@ jobs:
         registry-url: 'https://registry.npmjs.org'
     - run: npm ci
     - run: npm run build
-    - run: npx playwright install-deps
     - run: utils/publish_all_packages.sh --release-candidate
       if: ${{ github.event.release.prerelease }}
       env: