Refactor process_lost_frames into a separate function#2494
Open
antoniovicente wants to merge 1 commit into
Open
Refactor process_lost_frames into a separate function#2494antoniovicente wants to merge 1 commit into
antoniovicente wants to merge 1 commit into
Conversation
send_single is already too long. We should think of processing of lost frames as a different operation
gregor-cf
approved these changes
May 26, 2026
gregor-cf
left a comment
gregor-cf
left a comment
Contributor
There was a problem hiding this comment.
Yes, please!!! This is great.
| ); | ||
|
|
||
| q.add_event_data_with_instant(ev_data, now) | ||
| q.add_event_data_with_instant(ev_data, _now) |
Contributor
There was a problem hiding this comment.
We should remove the underscore IMHO. If clippy complains that now is not used when qlog is disabled, I'd just add an annotation to send_single to allow unused args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_single is already too long. We should think of processing of lost frames as a different operation