qlog,quiche,tokio-quiche: add QlogSink abstraction for custom qlogs#2500
Open
strtok wants to merge 1 commit into
Open
qlog,quiche,tokio-quiche: add QlogSink abstraction for custom qlogs#2500strtok wants to merge 1 commit into
strtok wants to merge 1 commit into
Conversation
gregor-cf
reviewed
Jun 1, 2026
gregor-cf
left a comment
gregor-cf
left a comment
Contributor
There was a problem hiding this comment.
This is great. I did a quick pass and had some minor comments and nits.
| fn add_event(&mut self, event: events::Event) -> Result<()>; | ||
|
|
||
| /// Add a pretty-printed native qlog event to the stream. | ||
| fn add_event_pretty(&mut self, event: events::Event) -> Result<()> { |
Contributor
There was a problem hiding this comment.
I would remove the `pretty functions. The sink might not actually have a serialization or similar that can do pretty printing. IMHO if pretty printing is desired, then we that should be handled by the sink / writer internally, but it shouldn't be exposed to callers of QlogSink.
But I'll let the folks who orginally added the QlogStreamer chime in.
| /// Writes a serializable to a pretty-printed JSON-SEQ record using | ||
| /// [std::time::Instant::now()]. | ||
| pub fn add_event_now_pretty<E: Serialize + Eventable>( | ||
| pub fn add_event_now_pretty<E: Into<crate::QlogEvent> + Eventable>( |
Contributor
There was a problem hiding this comment.
nit: I'd remove the _pretty functions here too....
csujedihy
reviewed
Jun 1, 2026
…iting
Add a QlogSink trait that allows overriding qlog behavior. Previously
QlogStreamer was instantiated with a writer object. Instead, it is
instantiated with a QlogSink object which allows more flexibility. A
QlogWriterSink implementation provides backwards compatibility.
Implementations have new methods for overriding qlog behavior:
- Connection::set_qlog_sink and set_qlog_sink_with_level allow setting
a custom qlog sink. The existing set_qlog and set_qlog_with_level
exist for backwards compatibility and call these new functions with
a QlogWriterSink object.
- A new ConnectionHook::create_qlog_sink hook can be implemented to
install a sink at connection accept/connect time. If a sink is
returned it overrides any qlog_dir behavior.
Add QlogStreamer::should_log(EventType) that allows high volume events
to be skipped without construction. Modified both the recv and write
path to make use of this.
Remove QlogStreamer::writer. A QlogStreamer is no longer guaranteed to
be backed by a Writer. The underlying QlogSink is exposed via
QlogStreamer::sink(), where it's used by tests to access the underlying
test sink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a QlogSink trait that allows overriding qlog behavior. Previously QlogStreamer was instantiated with a writer object. Instead, it is instantiated with a QlogSink object which allows more flexibility. A QlogWriterSink implementation provides backwards compatibility.
Implementations have new methods for overriding qlog behavior:
Add QlogStreamer::should_log(EventType) that allows high volume events to be skipped without construction. Modified both the recv and write path to make use of this.