Trust injected CA certificate on sandbox startup#550
Open
Conversation
🦋 Changeset detectedLatest commit: 441043a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
🐳 Docker Images Published
Usage: FROM cloudflare/sandbox:0.0.0-pr-550-441043aVersion: 📦 Standalone BinaryFor arbitrary Dockerfiles: COPY --from=cloudflare/sandbox:0.0.0-pr-550-441043a /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]Download via GitHub CLI: gh run download 23860614832 -n sandbox-binaryExtract from Docker: docker run --rm cloudflare/sandbox:0.0.0-pr-550-441043a cat /container-server/sandbox > sandbox && chmod +x sandbox |
Contributor
Author
|
/bonk review this PR |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@scuffi Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
scuffi
force-pushed
the
load-runtime-intercept-ca-cert
branch
from
57c223d to
441043a
Compare
Contributor
Author
|
/bonk review this PR |
Contributor
|
UnknownError: ProviderInitError |
scuffi
requested review from
aron-cf,
ghostwriternr and
whoiskatrin
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To support HTTPS egress interception, we must trust an injected CA certificate into external requests. This PR adds a blocking loader to fetch & trust this certificate during container server startup. In production, this certificate will exist at startup, so there should be minimal overhead introduced. The polling/blocking mechanism is for local development to ensure parity as the certificate cannot be assumed to exist at startup due to Docker API limitations.
Request Support
We are doing a 'best-effort' approach here by populating commonly used CA certificate environment variables, however, this approach is always going to be limited by packages or processes that ignore common system CA certificates, which we won't be able to intercept.