-
Notifications
You must be signed in to change notification settings - Fork 24
Description
config.json has an absolute path for the browserConfig.recordVideo.dir path. This looks to be a mutation from playwright execution and outside of the scope of telescope.
Suggestion is to clone the config prior to running the test in Playwright and use the cloned object for config.json.
This will need to be decided before a --config parameter is finalized.
Relates to #62
Telescope info
Telescope version: bc065d4
Node version: v23.11.0
Operating system version:MacOS Tahoe 26.1
Steps to reproduce
Run npx . -u https://example.com. Open config.json in the results directory. Note that browserConfig.recordVideo.dir is an absolute path.
Expected results
A relative path similar to the browserConfig.recordHar.path value.
Observed results
Absolute path for thebrowserConfig.recordHar.path value.
Additional context
The config is mutated during playwright execution.
//testRunner.js
//line 90
console.log('selectedBrowserbeforelaunch', (this.selectedBrowser||{}).recordVideo.dir);
const browser = await playwright[
this.selectedBrowser.engine
].launchPersistentContext(
this.paths['temporaryContext'],
this.selectedBrowser,
);
console.log('selectedBrowserafterlaunch', (this.selectedBrowser||{}).recordVideo.dir); Output
selectedBrowserbeforelaunch: ./results/2025_12_08_20_22_07_adfd4d75
selectedBrowserafterlaunch: /Users/mjkozicki//telescope/results/2025_12_08_20_22_07_adfd4d75