Skip to content

fix(app): apply layout segment config to pages#993

Open
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406:nathan/layout-segment-config
Open

fix(app): apply layout segment config to pages#993
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406:nathan/layout-segment-config

Conversation

@NathanDrake2406
Copy link
Copy Markdown
Contributor

@NathanDrake2406 NathanDrake2406 commented Apr 30, 2026

Summary

  • resolve App page segment config from the full matched layout -> page module chain instead of only route.page
  • apply layout-level dynamic, revalidate, dynamicParams, and fetchCache to App page request handling
  • keep codegen thin: the generated RSC entry lists route modules and delegates config reduction to server/app-segment-config

Next.js compatibility evidence

Tests

  • vp test run tests/app-segment-config.test.ts tests/fetch-cache.test.ts tests/entry-templates.test.ts
  • vp test run tests/app-router.test.ts -t "dynamicParams = false exported from a layout|revalidate exported from a layout|force-dynamic' exported from a layout"
  • vp check packages/vinext/src/server/app-segment-config.ts packages/vinext/src/shims/fetch-cache.ts packages/vinext/src/shims/unified-request-context.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-segment-config.test.ts tests/fetch-cache.test.ts tests/app-router.test.ts

Copilot AI review requested due to automatic review settings April 30, 2026 10:57
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 30, 2026

Open in StackBlitz

npm i https://pkg.pr.new/vinext@993

commit: 1e54b39

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants