Skip to content

Commit 95d305f

Browse files
danlapidguybedford
andcommitted
Apply suggestions from code review
Co-authored-by: Guy Bedford <guybedford@gmail.com> Co-authored-by: Dan Lapid <dan.lapid@gmail.com>
1 parent c0f8dcf commit 95d305f

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/node/internal/internal_process.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,10 @@ export const config = Object.freeze({
300300
node_use_node_code_cache: false,
301301
node_use_node_snapshot: false,
302302
node_use_openssl: true,
303-
node_use_sqlite: true,
304-
node_use_v8_platform: true,
303+
node_use_sqlite: false,
304+
node_use_v8_platform: false,
305305
node_with_ltcg: false,
306-
node_without_node_options: false,
306+
node_without_node_options: true,
307307
node_write_snapshot_as_array_literals: false,
308308
openssl_is_fips: false,
309309
openssl_quic: false,
@@ -322,7 +322,7 @@ export const config = Object.freeze({
322322
v8_enable_hugepage: 0,
323323
v8_enable_i18n_support: 1,
324324
v8_enable_inspector: 0,
325-
v8_enable_javascript_promise_hooks: 1,
325+
v8_enable_javascript_promise_hooks: 0,
326326
v8_enable_lite_mode: 0,
327327
v8_enable_maglev: 1,
328328
v8_enable_object_print: 0,

src/node/module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ Module.prototype._compile = function _compile(): void {
239239
};
240240

241241
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
242-
Module.prototype.isPreloading = false;
242+
Object.defineProperty(Module.prototype, 'isPreloading', { get() { return false; } })
243243

244244
Object.defineProperties(Module, {
245245
register: {

0 commit comments

Comments
 (0)