Avoid inspector stack capture in RPC GC finalizers - #7255
Open
ruifigueira wants to merge 1 commit into
Open
Conversation
Skip V8 stack collection for RPC disposal warnings emitted during GC. Add an inspector-enabled regression covering optimized string flattening and explicit disposal.
danlapid
reviewed
Sep 6, 2026
| params.setExecutionContextId(v8_inspector::V8ContextInfo::executionContextId(js.v8Context())); | ||
| params.setTimestamp(impl->inspectorClient->currentTimeMS()); | ||
| stackTraceToCDP(js, params.initStackTrace()); | ||
| if (captureStackTrace) { |
Collaborator
There was a problem hiding this comment.
Instead of passing this parameter everywhere couldn't we just check with v8 whether JavaScript execution is disabled or whatever it's called and not capture stack trace in that case?
Author
There was a problem hiding this comment.
I tried automatic detection with jsg::isInGcDestructor() but it failed because the RPC finalizer runs from the GC epilogue, where that function returns false 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When V8 garbage-collects a leaked RPC stub, its C++ destructor logs a disposal warning. If the inspector is enabled, logging also captures the current JavaScript stack.
The garbage collection can interrupt optimized JavaScript at a point where V8 cannot safely reconstruct that stack. Attempting to capture it then triggers a V8
CHECKand crashes the process.The fix keeps the warning but omits its inspector stack trace when emitted from RPC GC finalizers.