Skip to content

Commit cc3090c

Browse files
committed
test unsafe-single-threaded-traits
1 parent 8401dcc commit cc3090c

File tree

7 files changed

+14
-18
lines changed

7 files changed

+14
-18
lines changed

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ js-sys = { version = "0.3.82", path = "./wasm-bindgen/crates/js-sys" }
2424
serde = { version = "1.0.164", features = ["derive"] }
2525
serde_json = "1.0.140"
2626
serde-wasm-bindgen = "0.6.5"
27-
wasm-bindgen = { version = "0.2.105", path = "./wasm-bindgen" }
27+
wasm-bindgen = { version = "0.2.105", path = "./wasm-bindgen", features = ["unsafe-single-threaded-traits"] }
2828
wasm-bindgen-cli-support = { version = "0.2.105", path = "./wasm-bindgen/crates/cli-support" }
29-
wasm-bindgen-futures = { version = "0.4.54", path = "./wasm-bindgen/crates/futures" }
29+
wasm-bindgen-futures = { version = "0.4.54", path = "./wasm-bindgen/crates/futures", features = ["unsafe-single-threaded-traits"] }
3030
wasm-bindgen-macro-support = { version = "0.2.105", path = "./wasm-bindgen/crates/macro-support" }
3131
wasm-bindgen-shared = { version = "0.2.105", path = "./wasm-bindgen/crates/shared" }
3232
wasm-bindgen-test = { version = "0.3.50", path = "./wasm-bindgen/crates/test" }

examples/rpc-client/src/calculator.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,18 @@ mod sys {
2222
pub trait Calculator {
2323
async fn add(&self, a: u32, b: u32) -> ::worker::Result<u64>;
2424
}
25-
pub struct CalculatorService(::worker::send::SendWrapper<sys::CalculatorSys>);
25+
pub struct CalculatorService(sys::CalculatorSys);
2626
#[async_trait::async_trait]
2727
impl Calculator for CalculatorService {
2828
async fn add(&self, a: u32, b: u32) -> ::worker::Result<u32> {
2929
let promise = self.0.add(a, b)?;
30-
let fut = ::worker::send::SendFuture::new(
31-
::worker::wasm_bindgen_futures::JsFuture::from(promise),
32-
);
30+
let fut = ::worker::wasm_bindgen_futures::JsFuture::from(promise);
3331
let output = fut.await?;
3432
Ok(::serde_wasm_bindgen::from_value(output)?)
3533
}
3634
}
3735
impl From<::worker::Fetcher> for CalculatorService {
3836
fn from(fetcher: ::worker::Fetcher) -> Self {
39-
Self(::worker::send::SendWrapper::new(fetcher.into_rpc()))
37+
Self(fetcher.into_rpc())
4038
}
4139
}

test/src/analytics_engine.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,5 @@ pub async fn handle_analytics_event(
3030
.add_double(200)
3131
.write_to(&dataset)?;
3232

33-
return Response::ok("Events sent");
33+
Response::ok("Events sent")
3434
}

test/src/socket.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ pub async fn handle_socket_failed(
1111
let socket = ConnectionBuilder::new().connect("127.0.0.1", 25000)?;
1212

1313
match socket.opened().await {
14-
Ok(_) => {
15-
return Err(Error::RustError(
16-
"Socket should have failed to open.".to_owned(),
17-
))
18-
}
14+
Ok(_) => Err(Error::RustError(
15+
"Socket should have failed to open.".to_owned(),
16+
)),
1917
Err(e) => Response::ok(format!("{e:?}")),
2018
}
2119
}

worker-codegen/src/wit.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ fn expand_trait(interface: &Interface, interface_name: &Ident) -> anyhow::Result
8585

8686
fn expand_struct(struct_name: &Ident, sys_name: &Ident) -> anyhow::Result<syn::ItemStruct> {
8787
let struct_raw = quote!(
88-
pub struct #struct_name(::worker::send::SendWrapper<sys::#sys_name>);
88+
pub struct #struct_name(sys::#sys_name);
8989
);
9090
let struct_item: syn::ItemStruct = syn::parse2(struct_raw)?;
9191
Ok(struct_item)
@@ -95,7 +95,7 @@ fn expand_from_impl(struct_name: &Ident, from_type: &syn::Type) -> anyhow::Resul
9595
let impl_raw = quote!(
9696
impl From<#from_type> for #struct_name {
9797
fn from(fetcher: #from_type) -> Self {
98-
Self(::worker::send::SendWrapper::new(fetcher.into_rpc()))
98+
Self(fetcher.into_rpc())
9999
}
100100
}
101101
);
@@ -144,7 +144,7 @@ fn expand_rpc_impl(
144144
let method_raw = quote!(
145145
async fn #ident(&self) -> ::worker::Result<#ret_type> {
146146
let promise = #invocation_item?;
147-
let fut = ::worker::send::SendFuture::new(::worker::wasm_bindgen_futures::JsFuture::from(promise));
147+
let fut = ::worker::wasm_bindgen_futures::JsFuture::from(promise);
148148
let output = fut.await?;
149149
Ok(::serde_wasm_bindgen::from_value(output)?)
150150
}

worker/src/websocket.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ async fn fetch_with_request_raw(request: crate::Request) -> Result<web_sys::Resp
462462
let req = request.inner();
463463
let fut = {
464464
let worker: web_sys::WorkerGlobalScope = js_sys::global().unchecked_into();
465-
crate::send::SendFuture::new(JsFuture::from(worker.fetch_with_request(req)))
465+
JsFuture::from(worker.fetch_with_request(req))
466466
};
467467
let resp = fut.await?;
468468
Ok(resp.dyn_into()?)

0 commit comments

Comments
 (0)