Skip to content

Commit 366160a

Browse files
committed
fix: fix data_source rule permission
'DOMAIN_OWNER' -> 'DOMAIN_ADMIN'
1 parent eb3e2a1 commit 366160a

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/spaceone/cost_analysis/manager/data_source_rule_manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def _get_service_account(
196196
{"k": target_key, "v": target_value, "o": "eq"},
197197
{"k": "domain_id", "v": domain_id, "o": "eq"},
198198
],
199-
"only": ["service_account_id", "project_id", "workspace_id"],
199+
"only": ["service_account_id", "project_id", "workspace_id", "tags"],
200200
}
201201

202202
if workspace_id:

src/spaceone/cost_analysis/service/data_source_rule_service.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def __init__(self, *args, **kwargs):
4141

4242
@transaction(
4343
permission="cost-analysis:DataSourceRule.write",
44-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER"],
44+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER"],
4545
)
4646
def create(self, params):
4747
"""Create data source rule
@@ -114,7 +114,7 @@ def create_data_source_rule(self, params):
114114

115115
@transaction(
116116
permission="cost-analysis:DataSourceRule.write",
117-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER"],
117+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER"],
118118
)
119119
@check_required(["data_source_rule_id", "domain_id"])
120120
@change_date_value(["end"])
@@ -169,7 +169,7 @@ def update(self, params):
169169

170170
@transaction(
171171
permission="cost-analysis:DataSourceRule.write",
172-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER"],
172+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER"],
173173
)
174174
@check_required(["data_source_rule_id", "order", "domain_id"])
175175
def change_order(self, params):
@@ -242,7 +242,7 @@ def change_order(self, params):
242242

243243
@transaction(
244244
permission="cost-analysis:DataSourceRule.write",
245-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER"],
245+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER"],
246246
)
247247
@check_required(["data_source_rule_id", "domain_id"])
248248
def delete(self, params):
@@ -288,7 +288,7 @@ def delete(self, params):
288288

289289
@transaction(
290290
permission="cost-analysis:DataSourceRule.read",
291-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER", "WORKSPACE_MEMBER"],
291+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER", "WORKSPACE_MEMBER"],
292292
)
293293
@change_value_by_rule("APPEND", "workspace_id", "*")
294294
@check_required(["data_source_rule_id", "domain_id"])
@@ -316,7 +316,7 @@ def get(self, params):
316316

317317
@transaction(
318318
permission="cost-analysis:DataSourceRule.read",
319-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER", "WORKSPACE_MEMBER"],
319+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER", "WORKSPACE_MEMBER"],
320320
)
321321
@change_value_by_rule("APPEND", "workspace_id", "*")
322322
@check_required(["domain_id"])
@@ -347,7 +347,7 @@ def list(self, params):
347347

348348
@transaction(
349349
permission="cost-analysis:DataSourceRule.read",
350-
role_types=["DOMAIN_OWNER", "WORKSPACE_OWNER", "WORKSPACE_MEMBER"],
350+
role_types=["DOMAIN_ADMIN", "WORKSPACE_OWNER", "WORKSPACE_MEMBER"],
351351
)
352352
@change_value_by_rule("APPEND", "workspace_id", "*")
353353
@check_required(["query", "domain_id"])

0 commit comments

Comments
 (0)