Merge pull request #10 from whdalsrnt/master

whdalsrnt · web-flow · commit 2598a3218b0d · 2024-09-10T08:25:12.000+09:00
Change expiration time when downloading files
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,10 @@
+### Category
+- [ ] New feature
+- [ ] Bug fix
+- [ ] Improvement
+- [ ] Refactor
+- [ ] etc
+
+### Description
+
+### Known issue
diff --git a/src/spaceone/file_manager/connector/aws_s3_connector.py b/src/spaceone/file_manager/connector/aws_s3_connector.py
@@ -51,7 +51,7 @@ def get_upload_url(self, file_id, file_name):
     def get_download_url(self, file_id, file_name):
         object_name = self._generate_object_name(file_id, file_name)
         response = self.client.generate_presigned_url(
-            "get_object", Params={"Bucket": self.bucket_name, "Key": object_name}
+            "get_object", Params={"Bucket": self.bucket_name, "Key": object_name}, ExpiresIn=86400
         )
 
         return response

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def get_upload_url(self, file_id, file_name):`
`51`	`51`	`def get_download_url(self, file_id, file_name):`
`52`	`52`	`object_name = self._generate_object_name(file_id, file_name)`
`53`	`53`	`response = self.client.generate_presigned_url(`
`54`		`- "get_object", Params={"Bucket": self.bucket_name, "Key": object_name}`
	`54`	`+ "get_object", Params={"Bucket": self.bucket_name, "Key": object_name}, ExpiresIn=86400`
`55`	`55`	`)`
`56`	`56`
`57`	`57`	`return response`