Merge pull request #434 from ImMin5/master

ImMin5 · web-flow · commit 3be9543d11ca · 2025-02-26T09:33:26.000+09:00
feat: remove set_query_page_limit decorator at list of sa
diff --git a/src/spaceone/identity/service/service_account_service.py b/src/spaceone/identity/service/service_account_service.py
@@ -186,7 +186,8 @@ def update(
             )
 
         if (
-            service_account_vo.secret_id and params.project_id
+            service_account_vo.secret_id
+            and params.project_id
             and service_account_vo.project_id != params.project_id
         ):
             secret_manager = SecretManager()
@@ -418,7 +419,7 @@ def get(
         ]
     )
     @append_keyword_filter(["service_account_id", "name"])
-    # @set_query_page_limit(2000)
+    @set_query_page_limit(2000)
     @convert_model
     def list(
         self, params: ServiceAccountSearchQueryRequest

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,8 @@ def update(`
`186`	`186`	`)`
`187`	`187`
`188`	`188`	`if (`
`189`		`- service_account_vo.secret_id and params.project_id`
	`189`	`+ service_account_vo.secret_id`
	`190`	`+ and params.project_id`
`190`	`191`	`and service_account_vo.project_id != params.project_id`
`191`	`192`	`):`
`192`	`193`	`secret_manager = SecretManager()`
`@@ -418,7 +419,7 @@ def get(`
`418`	`419`	`]`
`419`	`420`	`)`
`420`	`421`	`@append_keyword_filter(["service_account_id", "name"])`
`421`		`- # @set_query_page_limit(2000)`
	`422`	`+ @set_query_page_limit(2000)`
`422`	`423`	`@convert_model`
`423`	`424`	`def list(`
`424`	`425`	`self, params: ServiceAccountSearchQueryRequest`