Skip to content

Commit e2d1e8f

Browse files
Merge pull request #133 from jinyoungmoonDEV/master
fix: add tags for cloudwatch
2 parents f1b3299 + 12a7727 commit e2d1e8f

File tree

2 files changed

+34
-28
lines changed

2 files changed

+34
-28
lines changed

src/spaceone/inventory/conf/cloud_service_conf.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,34 +12,34 @@
1212
DEFAULT_VULNERABLE_PORTS = "22,3306"
1313

1414
CLOUD_SERVICE_GROUP_MAP = {
15-
"IAM": "IAMConnectorManager",
16-
"DynamoDB": "DynamoDBConnectorManager",
17-
"Lambda": "LambdaConnectorManager",
18-
"CloudFront": "CloudFrontConnectorManager",
19-
"RDS": "RDSConnectorManager",
20-
"Route53": "Route53ConnectorManager",
21-
"S3": "S3ConnectorManager",
22-
"ElastiCache": "ElastiCacheConnectorManager",
23-
"APIGateway": "APIGatewayConnectorManager",
24-
"DirectConnect": "DirectConnectConnectorManager",
25-
"EFS": "EFSConnectorManager",
26-
"DocumentDB": "DocumentDBConnectorManager",
27-
"ECS": "ECSConnectorManager",
28-
"Redshift": "RedshiftConnectorManager",
29-
"EKS": "EKSConnectorManager",
30-
"SQS": "SQSConnectorManager",
31-
"KMS": "KMSConnectorManager",
32-
"ECR": "ECRConnectorManager",
33-
"CloudTrail": "CloudTrailConnectorManager",
34-
"SNS": "SNSConnectorManager",
35-
"SecretsManager": "SecretsManagerConnectorManager",
36-
"ELB": "ELBConnectorManager",
37-
"VPC": "VPCConnectorManager",
38-
"ACM": "ACMConnectorManager",
39-
"KinesisDataStream": "KinesisDataStreamConnectorManager",
40-
"MSK": "MSKConnectorManager",
41-
"KinesisFirehose": "KinesisFirehoseConnectorManager",
42-
"Lightsail": "LightsailConnectorManager",
15+
# "IAM": "IAMConnectorManager",
16+
# "DynamoDB": "DynamoDBConnectorManager",
17+
# "Lambda": "LambdaConnectorManager",
18+
# "CloudFront": "CloudFrontConnectorManager",
19+
# "RDS": "RDSConnectorManager",
20+
# "Route53": "Route53ConnectorManager",
21+
# "S3": "S3ConnectorManager",
22+
# "ElastiCache": "ElastiCacheConnectorManager",
23+
# "APIGateway": "APIGatewayConnectorManager",
24+
# "DirectConnect": "DirectConnectConnectorManager",
25+
# "EFS": "EFSConnectorManager",
26+
# "DocumentDB": "DocumentDBConnectorManager",
27+
# "ECS": "ECSConnectorManager",
28+
# "Redshift": "RedshiftConnectorManager",
29+
# "EKS": "EKSConnectorManager",
30+
# "SQS": "SQSConnectorManager",
31+
# "KMS": "KMSConnectorManager",
32+
# "ECR": "ECRConnectorManager",
33+
# "CloudTrail": "CloudTrailConnectorManager",
34+
# "SNS": "SNSConnectorManager",
35+
# "SecretsManager": "SecretsManagerConnectorManager",
36+
# "ELB": "ELBConnectorManager",
37+
# "VPC": "VPCConnectorManager",
38+
# "ACM": "ACMConnectorManager",
39+
# "KinesisDataStream": "KinesisDataStreamConnectorManager",
40+
# "MSK": "MSKConnectorManager",
41+
# "KinesisFirehose": "KinesisFirehoseConnectorManager",
42+
# "Lightsail": "LightsailConnectorManager",
4343
"CloudWatch": "CloudWatchConnectorManager",
4444
# Not used services
4545
# "EC2": "EC2ConnectorManager",

src/spaceone/inventory/connector/aws_cloud_watch_connector/connector.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ def request_alarms_data(self, region_name: str) -> List[Table]:
8686
self._set_alarm_conditions(raw_alarm)
8787
self._set_alarm_actions(raw_alarm)
8888
self._set_alarm_history(raw_alarm)
89+
tags = self._get_alarms_tags(raw_alarm.get("AlarmArn"))
8990

9091
alarms_vo = Alarms(raw_alarm, strict=False)
9192
self.alarms.append(alarms_vo)
@@ -94,6 +95,7 @@ def request_alarms_data(self, region_name: str) -> List[Table]:
9495
"data": alarms_vo,
9596
"name": alarms_vo.name,
9697
"account": self.account_id,
98+
"tags": self.convert_tags_to_dict_type(tags)
9799
}
98100

99101
except Exception as e:
@@ -177,6 +179,10 @@ def _set_alarm_history(self, raw_alarm: Alarms) -> None:
177179
}
178180
)
179181

182+
def _get_alarms_tags(self, alarm_arn: str):
183+
response = self.client.list_tags_for_resource(ResourceARN=alarm_arn)
184+
return response["Tags"]
185+
180186
@staticmethod
181187
def _convert_int_type(value):
182188
if isinstance(value, float) and value.is_integer():

0 commit comments

Comments
 (0)