4244 stub security group space endpoints (#4266)

fixes #4244

Author: benjaminguttmann-avtq

api/handlers/space.go

@@ -19,11 +19,13 @@ import (
 )
 
 const (
-	SpacesPath                   = "/v3/spaces"
-	SpacePath                    = "/v3/spaces/{guid}"
-	RoutesForSpacePath           = "/v3/spaces/{guid}/routes"
-	SpaceFeaturePath             = "/v3/spaces/{guid}/features/{name}"
-	IsolationSegmentForSpacePath = "/v3/spaces/{guid}/relationships/isolation_segment"
+	SpacesPath                        = "/v3/spaces"
+	SpacePath                         = "/v3/spaces/{guid}"
+	RoutesForSpacePath                = "/v3/spaces/{guid}/routes"
+	SpaceFeaturePath                  = "/v3/spaces/{guid}/features/{name}"
+	IsolationSegmentForSpacePath      = "/v3/spaces/{guid}/relationships/isolation_segment"
+	RunningSecurityGroupsForSpacePath = "/v3/spaces/{guid}/running_security_groups"
+	StagingSecurityGroupsForSpacePath = "/v3/spaces/{guid}/staging_security_groups"
 )
 
 //counterfeiter:generate -o fake -fake-name CFSpaceRepository . CFSpaceRepository
@@ -204,6 +206,14 @@ func (h *Space) getIsolationSegment(r *http.Request) (*routing.Response, error)
 	return routing.NewResponse(http.StatusOK).WithBody(struct{}{}), nil
 }
 
+func (h *Space) getRunningSecurityGroups(r *http.Request) (*routing.Response, error) {
+	return routing.NewResponse(http.StatusOK).WithBody(presenter.ForList(presenter.Empty, repositories.ListResult[any]{}, h.apiBaseURL, *r.URL)), nil
+}
+
+func (h *Space) getStagingSecurityGroups(r *http.Request) (*routing.Response, error) {
+	return routing.NewResponse(http.StatusOK).WithBody(presenter.ForList(presenter.Empty, repositories.ListResult[any]{}, h.apiBaseURL, *r.URL)), nil
+}
+
 func (h *Space) getSpaceFeature(r *http.Request) (*routing.Response, error) {
 	logger := logr.FromContextOrDiscard(r.Context()).WithName("handlers.space.get-feature")
 
@@ -232,6 +242,8 @@ func (h *Space) AuthenticatedRoutes() []routing.Route {
 		{Method: "GET", Pattern: SpacePath, Handler: h.get},
 		{Method: "DELETE", Pattern: RoutesForSpacePath, Handler: h.deleteUnmappedRoutes},
 		{Method: "GET", Pattern: IsolationSegmentForSpacePath, Handler: h.getIsolationSegment},
+		{Method: "GET", Pattern: RunningSecurityGroupsForSpacePath, Handler: h.getRunningSecurityGroups},
+		{Method: "GET", Pattern: StagingSecurityGroupsForSpacePath, Handler: h.getStagingSecurityGroups},
 		{Method: "GET", Pattern: SpaceFeaturePath, Handler: h.getSpaceFeature},
 	}
 }

tests/e2e/spaces_test.go

@@ -474,4 +474,50 @@ var _ = Describe("Spaces", func() {
 			Expect(respUnmarshalled).To(HaveKeyWithValue("enabled", BeFalse()))
 		})
 	})
+
+	Describe("running_security_groups", func() {
+		var (
+			spaceGUID string
+			result    resource
+		)
+
+		BeforeEach(func() {
+			spaceGUID = createSpace(generateGUID("space"), commonTestOrgGUID)
+		})
+
+		JustBeforeEach(func() {
+			var err error
+			resp, err = adminClient.R().
+				SetResult(&result).
+				Get("/v3/spaces/" + spaceGUID + "/running_security_groups")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("returns StatusOK", func() {
+			Expect(resp).To(HaveRestyStatusCode(http.StatusOK))
+		})
+	})
+
+	Describe("staging_security_groups", func() {
+		var (
+			spaceGUID string
+			result    resource
+		)
+
+		BeforeEach(func() {
+			spaceGUID = createSpace(generateGUID("space"), commonTestOrgGUID)
+		})
+
+		JustBeforeEach(func() {
+			var err error
+			resp, err = adminClient.R().
+				SetResult(&result).
+				Get("/v3/spaces/" + spaceGUID + "/staging_security_groups")
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("returns StatusOK", func() {
+			Expect(resp).To(HaveRestyStatusCode(http.StatusOK))
+		})
+	})
 })

tests/smoke/spaces_test.go

@@ -35,4 +35,16 @@ var _ = Describe("Spaces", func() {
 			))
 		})
 	})
+
+	Describe("cf space", func() {
+		It("returns successful", func() {
+			session := helpers.Cf("space", spaceName)
+			Expect(session).To(Exit(0))
+
+			lines := it.MustCollect(it.LinesString(session.Out))
+			Expect(lines).To(ContainElement(
+				matchSubstrings(spaceName),
+			))
+		})
+	})
 })