Implement the /v3/apps/{guid}/manifest endpoint

Implementing the app manifest endpoint includes calliing the `CollectState` method which gives as full
information as possible for the `ManifestApplication` type
(Routes,Processes,Services,AppRecord,Droplet). The following changes are
made:

* Calling `GetDroplet` in `Collect state` to encapsulate the build
  record in the `AppState`
* Implementing `ToManifest` method to `AppState` type to map records to
  the `Manifest` types
* It turned out that the routes repository returns only the `GUID` not
  the full `DomainRecord`, so the domainrepo is injected in the route
  repository and gets the full domain record for a route. Also
  unneccesary look ups for the domain are removed from the route and
  domain handler
* Smoke test from the `cf create-app-manifest` command which calls the
  implemented manifest endpoint

Closes #4258

Author: uzabanov

api/actions/manifest/state_collector.go

@@ -5,12 +5,12 @@ import (
 	"errors"
 	"fmt"
 	"maps"
-	"path"
 	"slices"
 
 	"code.cloudfoundry.org/korifi/api/actions/shared"
 	"code.cloudfoundry.org/korifi/api/authorization"
 	apierrors "code.cloudfoundry.org/korifi/api/errors"
+
 	"code.cloudfoundry.org/korifi/api/repositories"
 	"code.cloudfoundry.org/korifi/api/tools/singleton"
 	"github.com/BooleanCat/go-functional/v2/it"
@@ -23,13 +23,15 @@ type StateCollector struct {
 	routeRepo           shared.CFRouteRepository
 	serviceInstanceRepo shared.CFServiceInstanceRepository
 	serviceBindingRepo  shared.CFServiceBindingRepository
+	dropletRepo         shared.CFDropletRepository
 }
 
 type AppState struct {
 	App             repositories.AppRecord
 	Processes       map[string]repositories.ProcessRecord
 	Routes          map[string]repositories.RouteRecord
 	ServiceBindings map[string]repositories.ServiceBindingRecord
+	Droplet         *repositories.DropletRecord
 }
 
 func NewStateCollector(
@@ -39,6 +41,7 @@ func NewStateCollector(
 	routeRepo shared.CFRouteRepository,
 	serviceInstanceRepo shared.CFServiceInstanceRepository,
 	serviceBindingRepo shared.CFServiceBindingRepository,
+	dropletRepo shared.CFDropletRepository,
 ) StateCollector {
 	return StateCollector{
 		appRepo:             appRepo,
@@ -47,6 +50,7 @@ func NewStateCollector(
 		routeRepo:           routeRepo,
 		serviceInstanceRepo: serviceInstanceRepo,
 		serviceBindingRepo:  serviceBindingRepo,
+		dropletRepo:         dropletRepo,
 	}
 }
 
@@ -82,11 +86,17 @@ func (s StateCollector) CollectState(ctx context.Context, authInfo authorization
 		return AppState{}, err
 	}
 
+	dropletRecord, err := s.getDroplet(ctx, authInfo, appRecord.DropletGUID)
+	if err != nil {
+		return AppState{}, err
+	}
+
 	return AppState{
 		App:             appRecord,
 		Processes:       processesByType,
 		Routes:          routesByURL,
 		ServiceBindings: bindingsByServiceName,
+		Droplet:         dropletRecord,
 	}, nil
 }
 
@@ -104,6 +114,18 @@ func (s StateCollector) indexProcessesByType(ctx context.Context, authInfo autho
 	}), nil
 }
 
+func (s StateCollector) getDroplet(ctx context.Context, authInfo authorization.Info, dropletGUID string) (*repositories.DropletRecord, error) {
+	droplet, err := s.dropletRepo.GetDroplet(ctx, authInfo, dropletGUID)
+	if err != nil {
+		if errors.As(err, new(apierrors.NotFoundError)) {
+			return nil, nil
+		}
+		return nil, err
+	}
+
+	return &droplet, nil
+}
+
 func (s StateCollector) indexRoutesByURL(ctx context.Context, authInfo authorization.Info, appGUID, spaceGUID string) (map[string]repositories.RouteRecord, error) {
 	routes, err := s.routeRepo.ListRoutes(ctx, authInfo, repositories.ListRoutesMessage{
 		AppGUIDs:   []string{appGUID},
@@ -113,9 +135,7 @@ func (s StateCollector) indexRoutesByURL(ctx context.Context, authInfo authoriza
 		return nil, err
 	}
 
-	return index(routes.Records, func(r repositories.RouteRecord) string {
-		return path.Join(fmt.Sprintf("%s.%s", r.Host, r.Domain.Name), r.Path)
-	}), nil
+	return index(routes.Records, routeURL), nil
 }
 
 func (s StateCollector) indexBindingsByServiceName(ctx context.Context, authInfo authorization.Info, appGUID string) (map[string]repositories.ServiceBindingRecord, error) {
@@ -169,3 +189,11 @@ func tryIndex[T any](records []T, keyFunc func(T) (string, error)) (map[string]T
 		recordsIter,
 	)), nil
 }
+
+func routeURL(route repositories.RouteRecord) string {
+	if route.Host == "" {
+		return fmt.Sprintf("%s%s", route.Domain.Name, route.Path)
+	}
+
+	return fmt.Sprintf("%s.%s%s", route.Host, route.Domain.Name, route.Path)
+}

api/actions/manifest/state_collector_test.go

@@ -12,6 +12,8 @@ import (
 	"code.cloudfoundry.org/korifi/api/authorization"
 	"code.cloudfoundry.org/korifi/api/repositories"
 	"code.cloudfoundry.org/korifi/api/repositories/k8sklient/descriptors"
+
+	apierrors "code.cloudfoundry.org/korifi/api/errors"
 )
 
 var _ = Describe("StateCollector", func() {
@@ -22,6 +24,7 @@ var _ = Describe("StateCollector", func() {
 		routeRepo           *fake.CFRouteRepository
 		serviceInstanceRepo *fake.CFServiceInstanceRepository
 		serviceBindingRepo  *fake.CFServiceBindingRepository
+		dropletRepo         *fake.CFDropletRepository
 		stateCollector      manifest.StateCollector
 		appState            manifest.AppState
 		collectStateErr     error
@@ -34,13 +37,15 @@ var _ = Describe("StateCollector", func() {
 		routeRepo = new(fake.CFRouteRepository)
 		serviceInstanceRepo = new(fake.CFServiceInstanceRepository)
 		serviceBindingRepo = new(fake.CFServiceBindingRepository)
+		dropletRepo = new(fake.CFDropletRepository)
 		stateCollector = manifest.NewStateCollector(
 			appRepo,
 			domainRepo,
 			processRepo,
 			routeRepo,
 			serviceInstanceRepo,
 			serviceBindingRepo,
+			dropletRepo,
 		)
 	})
 
@@ -90,6 +95,64 @@ var _ = Describe("StateCollector", func() {
 		})
 	})
 
+	Describe("droplet", func() {
+		BeforeEach(func() {
+			appRepo.ListAppsReturns(repositories.ListResult[repositories.AppRecord]{Records: []repositories.AppRecord{{GUID: "app-guid", DropletGUID: "droplet-guid"}}}, nil)
+			dropletRepo.GetDropletReturns(repositories.DropletRecord{
+				Lifecycle: repositories.Lifecycle{
+					Type: "buildpack",
+					Data: repositories.LifecycleData{
+						Buildpacks: []string{"bp1"},
+					},
+				},
+				AppGUID: "app-guid",
+				Image:   "docker-image",
+			}, nil)
+		})
+
+		It("gets the droplet", func() {
+			Expect(collectStateErr).NotTo(HaveOccurred())
+			Expect(dropletRepo.GetDropletCallCount()).To(Equal(1))
+			_, _, dropletGUID := dropletRepo.GetDropletArgsForCall(0)
+			Expect(dropletGUID).To(Equal("droplet-guid"))
+		})
+
+		It("returns the droplet", func() {
+			Expect(collectStateErr).NotTo(HaveOccurred())
+			Expect(appState.Droplet).To(Equal(&repositories.DropletRecord{
+				Lifecycle: repositories.Lifecycle{
+					Type: "buildpack",
+					Data: repositories.LifecycleData{
+						Buildpacks: []string{"bp1"},
+					},
+				},
+				AppGUID: "app-guid",
+				Image:   "docker-image",
+			}))
+		})
+
+		When("droplet is not found", func() {
+			BeforeEach(func() {
+				dropletRepo.GetDropletReturns(repositories.DropletRecord{}, apierrors.NewNotFoundError(nil, repositories.DropletResourceType, "droplet-guid"))
+			})
+
+			It("returns nil", func() {
+				Expect(collectStateErr).NotTo(HaveOccurred())
+				Expect(appState.Droplet).To(BeNil())
+			})
+		})
+
+		When("getting droplet fails", func() {
+			BeforeEach(func() {
+				dropletRepo.GetDropletReturns(repositories.DropletRecord{}, errors.New("get-droplet-error"))
+			})
+
+			It("returns the error", func() {
+				Expect(collectStateErr).To(MatchError("get-droplet-error"))
+			})
+		})
+	})
+
 	Describe("processes", func() {
 		BeforeEach(func() {
 			appRepo.ListAppsReturns(repositories.ListResult[repositories.AppRecord]{Records: []repositories.AppRecord{{GUID: "app-guid"}}}, nil)

api/actions/shared/fake/cfdroplet_repository.go

@@ -53,3 +53,8 @@ type CFServiceBindingRepository interface {
 type CFServiceInstanceRepository interface {
 	ListServiceInstances(context.Context, authorization.Info, repositories.ListServiceInstanceMessage) (repositories.ListResult[repositories.ServiceInstanceRecord], error)
 }
+
+//counterfeiter:generate -o fake -fake-name CFDropletRepository . CFDropletRepository
+type CFDropletRepository interface {
+	GetDroplet(context.Context, authorization.Info, string) (repositories.DropletRecord, error)
+}