Skip to content

Commit 0f9d818

Browse files
committed
Remove redundant arguments in ModuleHooksAggregator
1 parent fc86da7 commit 0f9d818

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/util/ModuleHooksAggregator.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,17 @@ public List<Hook> aggregateHooks(List<HookPhase> currentHookPhasesForExecution)
2828

2929
private List<Hook> determineHooksForExecution(Map<String, List<String>> alreadyExecutedHooks,
3030
List<HookPhase> hookPhasesForCurrentStepPhase) {
31-
List<Hook> moduleHooksToExecuteOnCurrentStepPhase = collectHooksWithPhase(moduleToDeploy, hookPhasesForCurrentStepPhase);
31+
List<Hook> moduleHooksToExecuteOnCurrentStepPhase = collectHooksWithPhase(hookPhasesForCurrentStepPhase);
3232
return getHooksForExecution(alreadyExecutedHooks, moduleHooksToExecuteOnCurrentStepPhase, hookPhasesForCurrentStepPhase);
3333
}
3434

35-
private List<Hook> collectHooksWithPhase(Module moduleToDeploy, List<HookPhase> hookPhasesForCurrentStepPhase) {
36-
return getModuleHooks(moduleToDeploy).stream()
37-
.filter(hook -> shouldCollectHook(hook.getPhases(), hookPhasesForCurrentStepPhase))
38-
.collect(Collectors.toList());
35+
private List<Hook> collectHooksWithPhase(List<HookPhase> hookPhasesForCurrentStepPhase) {
36+
return getModuleHooks().stream()
37+
.filter(hook -> shouldCollectHook(hook.getPhases(), hookPhasesForCurrentStepPhase))
38+
.collect(Collectors.toList());
3939
}
4040

41-
private List<Hook> getModuleHooks(Module module) {
41+
private List<Hook> getModuleHooks() {
4242
return moduleToDeploy.getMajorSchemaVersion() < MAJOR_SCHEMA_VERSION_THREE ? Collections.emptyList() : moduleToDeploy.getHooks();
4343
}
4444

0 commit comments

Comments
 (0)