Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Error pattern to help with required component props #1690

Open
gerardo-rodriguez opened this issue Mar 28, 2022 · 4 comments · Fixed by #1937
Open

Add an Error pattern to help with required component props #1690

gerardo-rodriguez opened this issue Mar 28, 2022 · 4 comments · Fixed by #1937
Labels
👷 dev ✨ enhancement New feature or request

Comments

@gerardo-rodriguez
Copy link
Member

This is an idea @calebeby came up with as a way to help make sure required component props are not accidentally missed when using a given component.

Maybe you could do something with defined? Maybe render a message instead of the component if a given prop is not defined? 🤔

Oh yeah that might be helpful. IDK if it's worth it, but we could probably make a error pattern that is very visible/flashy and then go through all our patterns and make them render the error pattern if any of their required props are missing

It may not be a higher priority, but would be helpful throughout the implementation of the components.

@gerardo-rodriguez gerardo-rodriguez added ✨ enhancement New feature or request 👷 dev 🎨 design Requires visual, UX or UI design decisions labels Mar 28, 2022
@tylersticka
Copy link
Member

This is a good idea, but I'm going to move it outside of this project as something to pursue in the future.

@tylersticka
Copy link
Member

In terms of how this displays, it seems like this could be a new visual style for our Alert component rather than a brand-new component.

@AriannaChau AriannaChau self-assigned this Jul 7, 2022
@AriannaChau AriannaChau added size:5 and removed size:? labels Jul 11, 2022
@tylersticka
Copy link
Member

@AriannaChau Let's keep this out of the project because it isn't a launch blocker (but you can continue to work on the issue).

@tylersticka
Copy link
Member

tylersticka commented Jul 19, 2022

PR #1937 finished the design aspect of this issue, which was to create an error message pattern that could be used for the described functionality. Re-opening and labeling the issue to represent the work left to do.

@tylersticka tylersticka reopened this Jul 19, 2022
@tylersticka tylersticka removed the 🎨 design Requires visual, UX or UI design decisions label Jul 19, 2022
@tylersticka tylersticka removed the size:5 label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷 dev ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants