fix: address 5 code quality issues in description feature

1. Fix compile error: declare stackDescription in processStackFile
2. Gofmt already applied by autofix.ci (no-op)
3. Fix vacuous test in TestDescribeStacksNoDescriptionField
4. Add TestDescribeStacksHelmfileComponentDescription for coverage
5. Add CLI golden snapshot for --sections description filter"

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/6d2569f8-5d96-49fa-89ae-bc60931eebd3

Author: Copilot

internal/exec/describe_stacks_component_processor.go

@@ -92,6 +92,10 @@ func (p *describeStacksProcessor) processStackFile(stackFileName string, stackMa
 	// not "imports", but keeping reads before mutations avoids implicit ordering assumptions.
 	stackManifestName := getStackManifestName(stackMap)
 
+	// Extract stack-level description from the top-level "description" key.
+	// ProcessStackConfig already promotes metadata.description to the top level of the result map.
+	stackDescription, _ := stackMap[cfg.DescriptionSectionName].(string)
+
 	// Delete the stack-wide imports section (not needed in output).
 	delete(stackMap, "imports")
 

pkg/describe/describe_stacks_test.go

@@ -473,6 +473,39 @@ func TestDescribeStacksComponentDescription(t *testing.T) {
 	assert.Equal(t, "Top-level component for testing Atmos stack configuration.", description)
 }
 
+// TestDescribeStacksHelmfileComponentDescription verifies that the description field on a
+// helmfile component is included in the describe stacks output.
+func TestDescribeStacksHelmfileComponentDescription(t *testing.T) {
+	configAndStacksInfo := schema.ConfigAndStacksInfo{}
+
+	atmosConfig, err := cfg.InitCliConfig(configAndStacksInfo, true)
+	assert.Nil(t, err)
+
+	stack := "tenant1-ue2-dev"
+	components := []string{"echo-server"}
+	componentTypes := []string{"helmfile"}
+
+	stacks, err := ExecuteDescribeStacks(atmosConfig, stack, components, componentTypes, nil, false, false)
+	assert.Nil(t, err)
+	assert.NotNil(t, stacks)
+
+	stackMap, ok := stacks[stack].(map[string]any)
+	assert.True(t, ok, "stack entry should be a map")
+
+	componentsMap, ok := stackMap["components"].(map[string]any)
+	assert.True(t, ok, "stack should have components section")
+
+	helmfileMap, ok := componentsMap["helmfile"].(map[string]any)
+	assert.True(t, ok, "components should have helmfile section")
+
+	component, ok := helmfileMap["echo-server"].(map[string]any)
+	assert.True(t, ok, "helmfile should have echo-server")
+
+	description, ok := component["description"].(string)
+	assert.True(t, ok, "helmfile component should have description field")
+	assert.Equal(t, "Echo server helmfile component for testing.", description)
+}
+
 // TestDescribeStacksStackDescription verifies that the description field at the stack level
 // is included in the describe stacks output.
 func TestDescribeStacksStackDescription(t *testing.T) {
@@ -540,7 +573,7 @@ func TestDescribeStacksDescriptionSectionFilter(t *testing.T) {
 }
 
 // TestDescribeStacksNoDescriptionField verifies that components without a description field
-// don't have the description field in the output when it's empty and includeEmpty is false.
+// don't have the description key in the output at all.
 func TestDescribeStacksNoDescriptionField(t *testing.T) {
 	configAndStacksInfo := schema.ConfigAndStacksInfo{}
 
@@ -570,9 +603,7 @@ func TestDescribeStacksNoDescriptionField(t *testing.T) {
 	component, ok := terraformMap["test/test-component"].(map[string]any)
 	assert.True(t, ok, "terraform should have test/test-component")
 
-	// test/test-component has no description field - it should not appear as a non-empty string.
-	desc := component["description"]
-	if descStr, ok := desc.(string); ok {
-		assert.Empty(t, descStr, "description should be empty if not set in YAML")
-	}
+	// test/test-component has no metadata.description — the key must be absent entirely.
+	_, exists := component["description"]
+	assert.False(t, exists, "description key should be absent for component without metadata.description")
 }

tests/fixtures/scenarios/complete/stacks/catalog/helmfile/echo-server.yaml

@@ -3,5 +3,7 @@
 components:
   helmfile:
     echo-server:
+      metadata:
+        description: "Echo server helmfile component for testing."
       vars:
         installed: true

tests/fixtures/scenarios/stack-manifest-name-pattern/stacks/catalog/base.yaml

@@ -3,5 +3,6 @@ components:
     vpc:
       metadata:
         component: mock
+        description: "VPC mock component for testing."
       vars:
         enabled: true

tests/fixtures/scenarios/stack-manifest-name-pattern/stacks/without-explicit-name.yaml

@@ -2,6 +2,9 @@
 import:
   - catalog/base
 
+metadata:
+  description: "Development UW2 stack without explicit name."
+
 vars:
   environment: dev
   stage: uw2

tests/snapshots/TestCLICommands_describe_stacks_--sections_description.stderr.golden

@@ -433,3 +433,30 @@ tests:
     expect:
       diff: []
       exit_code: 0
+
+  - name: describe stacks --sections description
+    enabled: true
+    snapshot: true
+    description: "Verify that --sections description returns only the description fields for stacks and components"
+    workdir: "fixtures/scenarios/stack-manifest-name-pattern"
+    command: "atmos"
+    args:
+      - "describe"
+      - "stacks"
+      - "--stack"
+      - "dev-uw2"
+      - "--sections"
+      - "description"
+      - "--format"
+      - "json"
+    expect:
+      diff: []
+      valid:
+        - "json"
+      stdout:
+        - '"dev-uw2"'
+        - '"description"'
+        - '"Development UW2 stack without explicit name\."'
+        - '"vpc"'
+        - '"VPC mock component for testing\."'
+      exit_code: 0