fix: Update ui.* calls to match new void-return API

Main branch merged #1980 which removed error returns from ui.* functions.
Updated cmd/ci/status.go and cmd/terraform/planfile/*.go to match the
new API that doesn't return values.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: osterman

cmd/ci/status.go

@@ -212,7 +212,7 @@ func fillMissingSHA(ctx *repoContext) {
 
 // renderStatus renders the CI status to the terminal.
 func renderStatus(status *ci.Status) {
-	_ = ui.Writef("Relevant pull requests in %s\n\n", status.Repository)
+	ui.Writef("Relevant pull requests in %s\n\n", status.Repository)
 
 	// Current branch.
 	if status.CurrentBranch != nil {
@@ -221,15 +221,15 @@ func renderStatus(status *ci.Status) {
 
 	// PRs created by user.
 	if len(status.CreatedByUser) > 0 {
-		_ = ui.Writeln("\nCreated by you")
+		ui.Writeln("\nCreated by you")
 		for _, pr := range status.CreatedByUser {
 			renderPRStatus(pr)
 		}
 	}
 
 	// PRs requesting review.
 	if len(status.ReviewRequests) > 0 {
-		_ = ui.Writeln("\nRequesting a code review from you")
+		ui.Writeln("\nRequesting a code review from you")
 		for _, pr := range status.ReviewRequests {
 			renderPRStatus(pr)
 		}
@@ -238,23 +238,23 @@ func renderStatus(status *ci.Status) {
 
 // renderBranchStatus renders status for a branch.
 func renderBranchStatus(bs *ci.BranchStatus) {
-	_ = ui.Writeln("Current branch")
+	ui.Writeln("Current branch")
 
 	if bs.PullRequest != nil {
 		renderPRStatus(bs.PullRequest)
 	} else {
-		_ = ui.Writef("  Commit status for %s\n", truncateSHA(bs.CommitSHA))
+		ui.Writef("  Commit status for %s\n", truncateSHA(bs.CommitSHA))
 		renderChecks(bs.Checks, "  ")
-		_ = ui.Writeln("\n  No open pull request for current branch.")
+		ui.Writeln("\n  No open pull request for current branch.")
 	}
 }
 
 // renderPRStatus renders status for a pull request.
 func renderPRStatus(pr *ci.PRStatus) {
-	_ = ui.Writef("  #%d  %s [%s]\n", pr.Number, pr.Title, pr.Branch)
+	ui.Writef("  #%d  %s [%s]\n", pr.Number, pr.Title, pr.Branch)
 
 	if pr.AllPassed && len(pr.Checks) > 0 {
-		_ = ui.Writeln("    - All checks passing")
+		ui.Writeln("    - All checks passing")
 	} else {
 		renderChecks(pr.Checks, "    ")
 	}
@@ -264,7 +264,7 @@ func renderPRStatus(pr *ci.PRStatus) {
 func renderChecks(checks []*ci.CheckStatus, indent string) {
 	for _, check := range checks {
 		icon := getCheckIcon(check.CheckState())
-		_ = ui.Writef("%s- %s %s (%s)\n", indent, icon, check.Name, check.Conclusion)
+		ui.Writef("%s- %s %s (%s)\n", indent, icon, check.Name, check.Conclusion)
 	}
 }
 

cmd/terraform/planfile/delete.go

@@ -89,7 +89,7 @@ func runDelete(cmd *cobra.Command, args []string) error {
 		return err
 	}
 	if !exists {
-		_ = ui.Warning(fmt.Sprintf("Planfile does not exist: %s", opts.Key))
+		ui.Warning(fmt.Sprintf("Planfile does not exist: %s", opts.Key))
 		return nil
 	}
 
@@ -106,7 +106,7 @@ func runDelete(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	_ = ui.Success(fmt.Sprintf("Deleted planfile from %s: %s", store.Name(), opts.Key))
+	ui.Success(fmt.Sprintf("Deleted planfile from %s: %s", store.Name(), opts.Key))
 	return nil
 }
 

cmd/terraform/planfile/download.go

@@ -158,9 +158,9 @@ func writeToFile(outputPath string, reader io.Reader) error {
 
 // printDownloadSuccess prints the success message for a download.
 func printDownloadSuccess(storeName, key, outputPath string, metadata *planfile.Metadata) {
-	_ = ui.Success(fmt.Sprintf("Downloaded planfile from %s: %s -> %s", storeName, key, outputPath))
+	ui.Success(fmt.Sprintf("Downloaded planfile from %s: %s -> %s", storeName, key, outputPath))
 	if metadata != nil && metadata.Stack != "" {
-		_ = ui.Info(fmt.Sprintf("Stack: %s, Component: %s, SHA: %s", metadata.Stack, metadata.Component, metadata.SHA))
+		ui.Info(fmt.Sprintf("Stack: %s, Component: %s, SHA: %s", metadata.Stack, metadata.Component, metadata.SHA))
 	}
 }
 

cmd/terraform/planfile/upload.go

@@ -130,7 +130,7 @@ func runUpload(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	_ = ui.Success(fmt.Sprintf("Uploaded planfile to %s: %s", store.Name(), key))
+	ui.Success(fmt.Sprintf("Uploaded planfile to %s: %s", store.Name(), key))
 	return nil
 }