Vendored artefacts are targeted relative to the vendor.yaml file, not the base_path specified in atmos.yaml

[djmcgreal-cc]

Describe the Bug

Hi. I have a use case where it's desirable to have Atmos.yaml and vendor.yaml tucked away out of the main repository root.

I find that when I atmos vendor pull I can only seem to target relative to vendor.yaml's location, i.e:

Running atmos vendor pull puts the components/terraform directory adjacent to the vendor.yaml.

Expected Behavior

I would have strongly thought it wants to be relative to the atmos.yaml's base_path, otherwise, I don't understand the intent.

Steps to Reproduce

path/to/atmos.yaml

base_path: !repo-root

vendor:
  base_path: path/to/vendor.yaml

components:
  terraform:
    base_path: components/terraform
    apply_auto_approve: false
    deploy_run_init: true
    init_run_reconfigure: true
    auto_generate_backend_file: true

stacks:
  base_path: stacks
  included_paths:
    - "**/*"
  excluded_paths:
    - "**/_defaults.yaml"
  name_pattern: "{stage}"

logs:
  file: /dev/stderr
  level: Info

settings:
  list_merge_strategy: replace

path/to/vendor.yaml

apiVersion: atmos/v1
kind: AtmosVendorConfig
metadata:
  name: vendored
  description: vendoring
spec:
  sources:
    - component: "github/stargazers"
      source: "github.com/cloudposse/atmos.git//examples/demo-library/{{ .Component }}?ref={{.Version}}"
      version: "main"
      targets:
        - "components/terraform/{{ .Component }}/{{.Version}}"
      included_paths:
        - "**/*.tf"
        - "**/*.tfvars"
        - "**/*.md"
      tags:
        - demo
        - github

ATMOS_CLI_CONFIG_PATH=path/to/ atmos vendor pull pulls the component to path/to/... not !repo_root

Screenshots

No response

Environment

No response

Additional Context

No response

[thejrose1984]

Confirmed reproducible on main (commit bc6f3197)

Reproduction

Setup at /tmp/atmos-repro-2409:

• path/to/atmos.yaml with base_path: "/tmp/atmos-repro-2409" and vendor.base_path: path/to/vendor.yaml
• path/to/vendor.yaml with targets: ["components/terraform/{{ .Component }}/{{.Version}}"]

ATMOS_CLI_CONFIG_PATH=/tmp/atmos-repro-2409/path/to atmos vendor pull

Expected (relative to atmosConfig.BasePath):
/tmp/atmos-repro-2409/components/terraform/github/stargazers/main

Actual (relative to filepath.Dir(vendor.yaml)):
/tmp/atmos-repro-2409/path/to/components/terraform/github/stargazers/main

Root cause

internal/exec/vendor_utils.go:437:

targetPath := filepath.Join(params.VendorConfigFilePath, target)

params.VendorConfigFilePath is set at internal/exec/vendor_utils.go:206 to filepath.Dir(params.vendorConfigFileName) — the directory containing the resolved vendor.yaml, not atmosConfig.BasePath. That targetPath flows into copyToTargetWithPatterns(tempDir, p.targetPath, ...) at internal/exec/vendor_model.go:376, so it is the final on-disk destination.

Consequence: whenever vendor.base_path points somewhere other than the repo root, every targets: entry in vendor.yaml is anchored under that directory, regardless of base_path or components.terraform.base_path.

Suggested fix direction

Anchor targetPath on atmosConfig.BasePath rather than the vendor config's directory:

basePath := params.AtmosConfig.BasePath
if basePath == "" {
    basePath = params.VendorConfigFilePath
}
targetPath := filepath.Join(basePath, target)

Worth considering before patching:

• This is a behavior change for anyone whose atmos.yaml and vendor.yaml sit side-by-side and who relied on the current anchoring. A toggle (e.g. vendor.resolve_targets_from: atmos|vendor) may be the safer route if back-compat matters.
• The same VendorConfigFilePath join is used for imported vendor configs in processVendorImports (internal/exec/vendor_utils.go:458); the fix should cover both cases symmetrically.