Open
Conversation
When using regional NAT gateway, there is no need for maintaining separate routing tables. Default stays at 'zonal' availability mode, which can be changed to 'regional'. Fixes: cloudposse#228
gberenice
reviewed
Feb 17, 2026
| # calculate the global subnet index in the flattened aws_subnet.public list | ||
| nat_gateway_public_subnet_indices = local.nat_gateway_useful ? flatten([ | ||
| # Only used for zonal NAT gateways; regional NAT gateways don't need subnet placement | ||
| nat_gateway_public_subnet_indices = local.nat_gateway_useful && var.nat_gateway_availability_mode == "zonal" ? flatten([ |
There was a problem hiding this comment.
@StephenKing, could I ask you to shorten repeatable expressions like this to improve code readability?
E.g., local.nat_gateway_useful && var.nat_gateway_availability_mode == "zonal" -> local.zonal_nat_gateway_useful
|
/terratest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Implement support for AWS regional NAT gateways (
availability_mode = "regional").I'm a bit unhappy with the size of the change, but apparently there was before no possibility to have only one private route table for multiple subnets. This, however, has the disadvantage that any updates (esp. when done for failover architectures) require updates to multiple routing tables.
why
references
Terraform provider docs for
aws_nat_gatewascloses #228