Skip to content

feat: allow optionality of SSM params #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Benbentwo merged 1 commit into from
Oct 15, 2025
Merged

feat: allow optionality of SSM params #109

Benbentwo merged 1 commit into from
Oct 15, 2025

Conversation

@oycyc
Copy link
Contributor

@oycyc oycyc commented Oct 13, 2025 •
edited
Loading

what

  • Added a new variable ssm_parameters_enabled (boolean, defaults to true) to allow enabling/disabling all SSM parameter resources
  • Updated the count parameter for all 4 aws_ssm_parameter resources to respect this flag. The count is previously existing, so it does not change any TF Address.
  • This change is fully backwards compatible - without any configuration changes, all existing deployments will continue to work exactly as before since the default value is true, which provisions the SSM parameter.

why

  • There are cases where consumers don't to use SSM parameters or don't want SSM parameters created from this. The module currently forces ALL usage to provision SSM parameters.
  • Allows teams using alternative credential management solutions (e.g., Vault, Secrets Manager, etc.) to avoid creating unused SSM parameters

Reference

closes #68

Issue raised by community with couple of comments + upvotes: #68

@oycyc oycyc requested review from a team as code owners October 13, 2025 22:18
@oycyc oycyc requested review from hans-d and kevcube October 13, 2025 22:18
@mergify mergify bot added the triage Needs triage label Oct 13, 2025
@oycyc oycyc added minor New features that do not break anything and removed triage Needs triage labels Oct 13, 2025
@oycyc
Copy link
Contributor Author

oycyc commented Oct 13, 2025

/terratest

@oycyc oycyc mentioned this pull request Oct 13, 2025
Closed
@Benbentwo
Copy link
Member

Benbentwo commented Oct 15, 2025

Looks good, thanks

@Benbentwo Benbentwo merged commit 964072d into main Oct 15, 2025
48 checks passed
@Benbentwo Benbentwo deleted the feat/allow-optionality-of-ssm-params branch October 15, 2025 00:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

These changes were released in v3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

minor New features that do not break anything

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSM parameters should be optional

3 participants

@oycyc @Benbentwo