fix: Add unit tests for collectVisibleIds with grouped content display

Author: NathanZlion

src/collection-preferences/content-display/__tests__/utils.test.ts

@@ -1,5 +1,6 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
+import { collectVisibleIds } from '../../../../lib/components/collection-preferences/utils';
 import {
   buildOptionTree,
   getFilteredOptions,
@@ -299,3 +300,34 @@ describe('getFilteredOptions', () => {
     expect(result).toEqual([{ id: 'b', label: 'Beta', visible: true }]);
   });
 });
+
+describe('collectVisibleIds', () => {
+  it('collects visible leaf ids from grouped content display', () => {
+    const items = [
+      { id: 'id1', visible: true },
+      {
+        type: 'group' as const,
+        id: 'g1',
+        visible: true,
+        children: [
+          { id: 'id2', visible: true },
+          { id: 'id3', visible: false },
+        ],
+      },
+      { type: 'group' as const, id: 'g2', visible: true, children: [{ id: 'id4', visible: true }] },
+    ];
+    expect(collectVisibleIds(items, true)).toEqual(['id1', 'id2', 'id4']);
+  });
+
+  it('excludes children of non-visible groups', () => {
+    const items = [
+      {
+        type: 'group' as const,
+        id: 'g1',
+        visible: false,
+        children: [{ id: 'id1', visible: true }],
+      },
+    ];
+    expect(collectVisibleIds(items, true)).toEqual([]);
+  });
+});

src/collection-preferences/content-display/index.tsx

@@ -87,7 +87,7 @@ interface HierarchicalContentDisplayProps {
   ariaLabelledby?: string;
   ariaDescribedby?: string;
   i18nStrings: SortableAreaProps.DndAreaI18nStrings;
-  sortDisabled?: boolean;
+  sortDisabled: boolean;
   parentGroupLabel?: string;
 }
 
@@ -138,7 +138,7 @@ function HierarchicalContentDisplay({
   ariaLabelledby,
   ariaDescribedby,
   i18nStrings,
-  sortDisabled = false,
+  sortDisabled,
   parentGroupLabel,
 }: HierarchicalContentDisplayProps) {
   return (