Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5260 +/- ##
=======================================
Coverage 97.83% 97.84%
=======================================
Files 1008 1009 +1
Lines 32590 32604 +14
Branches 12098 12111 +13
=======================================
+ Hits 31886 31900 +14
Misses 698 698
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The status-cell highlight logic uses stored selection instead of effective selection, causing unselected items to lose highlighting in none or single selection modes.
1 open issue
What changed in this PR
Adds internal Style API v2 support to Cloudscape Table, enabling customization of headers, rows, cells, selection controls, and focus indicators.
Changes:
- Adds typed style slots and SCSS tokens, wired through table rendering and the container’s sticky-header shadow.
- Adds slot tests and an interactive demo covering grouped headers, nested rows, selection, and highlighting.
- Updates style documentation snapshots and generated CSS-property hashes.
| File | Description |
|---|---|
src/token/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/text-filter/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/tabs/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/table/thead.tsx |
Forwards header style slots. |
src/table/styles.scss |
Registers tokens and documents table slots. |
src/table/style-api.ts |
Defines typed slots and callback resolution. |
src/table/style-api.scss |
Defines shared tokens and focus styling. |
src/table/selection/selection-control.tsx |
Forwards checkbox and radio styling. |
src/table/selection/selection-cell.tsx |
Connects selection-cell and control slots. |
src/table/resizer/styles.scss |
Adds token-based styling and divider positioning. |
src/table/resizer/index.tsx |
Applies the edge-divider class. |
src/table/internal.tsx |
Resolves and distributes table style slots. |
src/table/header-cell/th-element.tsx |
Applies header-cell classes. |
src/table/header-cell/styles.scss |
Integrates header tokens and adjusts hover styling. |
src/table/header-cell/index.tsx |
Resolves column and sorting-indicator slots. |
src/table/header-cell/group-header-cell.tsx |
Resolves grouped-header styling. |
src/table/header-cell/common-props.ts |
Adds shared header styling props. |
src/table/body-cell/td-element.tsx |
Applies body-cell classes. |
src/table/body-cell/styles.scss |
Integrates background, selection, and focus tokens. |
src/table/__tests__/style-api.test.tsx |
Tests slot application and callback arguments. |
src/slider/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/segmented-control/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/item-card/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/input/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/dropdown/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/container/styles.scss |
Supports table-specific sticky-header shadows. |
src/container/__tests__/__snapshots__/styles.test.tsx.snap |
Refreshes CSS-property hashes. |
src/__tests__/snapshot-tests/__snapshots__/style-docs.test.ts.snap |
Records table and additional component style documentation. |
pages/table/style-api-v2.scss |
Defines demo styles using the new slots. |
pages/table/style-api-v2.page.tsx |
Adds an interactive table styling demo. |
build-tools/utils/custom-css-properties.js |
Registers the sticky-header shadow property. |
Review effort: Balanced
| statusHighlight === 'cells' && | ||
| args.type === 'data' && | ||
| args.column.id === 'state' && | ||
| !selectedItems.includes(args.item) && |
pan-kot
force-pushed
the
chore-style-api-v2-table
branch
from
November 6, 2026 17:04
34d2e2a to
d7d13d5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.