This repository was archived by the owner on Mar 30, 2021. It is now read-only.
Vrouter: support Ubuntu vrouter kernel module #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
suggested changes
Jul 11, 2019
Contributor
nlewo
left a comment
nlewo
left a comment
There was a problem hiding this comment.
If the goal is to load the module in a devstack, I think it would be better to provide a script to fetch kernel sources and build the vrouter module from the devstack itself becasue i think we can encounter to much different kernel versions.
| }; | ||
| in lself.lib.buildVrouter kernel; | ||
|
|
||
| vrouterModuleUbuntu_4_4_0_137_generic = let |
Contributor
There was a problem hiding this comment.
Can you add in a command for which ubuntu release it is?
| @@ -0,0 +1,33 @@ | |||
| { stdenv, fetchurl, patchelf, dpkg, rsync }: | |||
|
|
|||
| { version, amd64File, amd64Sha256, allFile, allSha256 }: | |||
Contributor
There was a problem hiding this comment.
I think amd64File, allFile strings can be generated from the version. Also, I think we could find better name for these files. You can see what apt description of theses packages.
| { version, amd64File, amd64Sha256, allFile, allSha256 }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| inherit version amd64File amd64Sha256 allFile allSha256; |
Contributor
There was a problem hiding this comment.
You only need to inherit version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.