Skip to content

Commit 83c8f8a

Browse files
authored
fix(volo-http, volo-grpc): fix wrong usage of span (#622)
* fix(volo-http, volo-grpc): fix wrong usage of span * chore(volo-grpc): bump volo-grpc to 0.11.6 --------- Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
1 parent a5d99d3 commit 83c8f8a

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

volo-grpc/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "volo-grpc"
3-
version = "0.11.5"
3+
version = "0.11.6"
44
edition.workspace = true
55
homepage.workspace = true
66
repository.workspace = true

volo-grpc/src/server/meta.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ use std::{cell::RefCell, net::SocketAddr, str::FromStr, sync::Arc, task::Poll};
22

33
use futures::{FutureExt, future::BoxFuture};
44
use metainfo::{Backward, Forward};
5+
use tracing::Instrument;
56
use volo::{FastStr, Service, context::Context};
67

78
use crate::{
@@ -125,8 +126,7 @@ where
125126
});
126127
status_to_http!(status);
127128
let span = span_provider.on_serve(&cx, metadata);
128-
let _enter = span.enter();
129-
let volo_resp = match inner.call(&mut cx, volo_req).await {
129+
let volo_resp = match inner.call(&mut cx, volo_req).instrument(span).await {
130130
Ok(resp) => resp,
131131
Err(err) => {
132132
span_provider.leave_serve(&cx);

volo-http/src/server/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ use motore::{
2727
use parking_lot::RwLock;
2828
use scopeguard::defer;
2929
use tokio::sync::Notify;
30+
use tracing::Instrument;
3031
#[cfg(feature = "__tls")]
3132
use volo::net::{conn::ConnStream, tls::Acceptor, tls::ServerTlsConfig};
3233
use volo::{
@@ -533,10 +534,10 @@ where
533534
let mut cx = ServerContext::new(service.peer);
534535
cx.rpc_info_mut().set_config(service.config);
535536
let span = service.span_provider.on_serve(&cx);
536-
let _enter = span.enter();
537537
let resp = service
538538
.inner
539539
.call(&mut cx, req.map(Body::from_incoming))
540+
.instrument(span)
540541
.await
541542
.into_response();
542543
service.span_provider.leave_serve(&cx);

0 commit comments

Comments
 (0)