Skip to content

Commit 93e9bfd

Browse files
Fix: Safely handle missing args in fileeditor:change-font-size label provider (jupyterlab#18157)
* fix(fileeditor): validate delta argument to avoid undefined access * style: fix formatting
1 parent 7a658a9 commit 93e9bfd

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

packages/fileeditor-extension/src/commands.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -263,20 +263,18 @@ export namespace Commands {
263263
});
264264
},
265265
label: args => {
266-
const delta = Number(args['delta']);
267-
if (Number.isNaN(delta)) {
268-
console.error(
269-
`${CommandIDs.changeFontSize}: delta arg must be a number`
270-
);
271-
}
266+
const delta = Number(args.delta ?? 0);
267+
272268
if (delta > 0) {
273269
return args.isMenu
274270
? trans.__('Increase Text Editor Font Size')
275271
: trans.__('Increase Font Size');
276-
} else {
272+
} else if (delta < 0) {
277273
return args.isMenu
278274
? trans.__('Decrease Text Editor Font Size')
279275
: trans.__('Decrease Font Size');
276+
} else {
277+
return trans.__('Change Font Size');
280278
}
281279
},
282280
describedBy: {

0 commit comments

Comments
 (0)