Tuple assignment error in Datacard renameNuisanceParameter

[GiacomoBoldrini]

renameNuisanceParameter method of Datacard class does not work because self.systs is a list of tuple.
The code searches for the old syst name entry in the list and tries to change the name by assignment on the tuple object

HiggsAnalysis-CombinedLimit/python/Datacard.py

Line 339 in 2a34f04

self.systs[nuisanceID][0] = newname

tested using latest combine image
gitlab-registry.cern.ch/cms-analysis/general/combine-container:CMSSW_14_1_0_pre4-combine_v10.0.1-harvester_v3.0.0-pre1

[kcormi]

Hi Giacomo,

Indeed, this might not have been properly updated reflecting some recent changes -- I think this function may be orphaned and fallen out of use. Where are you running into the error, are you using it in some private code?

[GiacomoBoldrini]

Hi Kyle,

Yes I am building a very simple framework on top of standard Combine tools for EFT combinations at datacard level. This function allows for easy uncertainties renaming. I find it pretty useful.

We are running the function with a dirty fix converting the tuple to list and then back to tuple.

# allow to modify this
nuis_entry = list(DC.systs[nuisanceID])
nuis_entry[0] = newname
DC.systs[nuisanceID] = tuple(nuis_entry)