Skip to content

Commit 87fa6bd

Browse files
authored
Merge pull request #49397 from mmusich/mm_make_pixel_gpu_on_demand
Monitoring of Pixel tracking SoAs: partial revert of #49340 and #49237
2 parents 01baf00 + a4ac4d6 commit 87fa6bd

File tree

4 files changed

+52
-5
lines changed

4 files changed

+52
-5
lines changed

DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.py

Lines changed: 48 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,13 @@
9090
process.load('DQM.SiPixelHeterogeneous.SiPixelHeterogenousDQMHarvesting_cff')
9191
process.siPixelTrackComparisonHarvesterAlpaka.topFolderName = cms.string('SiPixelHeterogeneous/PixelTrackCompareGPUvsCPU')
9292

93+
#-------------------------------------
94+
# User switches for what to monitor
95+
#-------------------------------------
96+
doRecHits = False
97+
doTracks = True
98+
doVertices = True
99+
93100
#-------------------------------------
94101
# Some Settings before Finishing up
95102
#-------------------------------------
@@ -179,12 +186,51 @@
179186
process.dump = cms.EDAnalyzer("EventContentAnalyzer")
180187
process.dumpPath = cms.Path(process.dump)
181188

189+
#-------------------------------------
190+
# Build the monitoring sequence based on flags
191+
#-------------------------------------
192+
monitoring_modules = []
193+
194+
# Mandatory pixel digi error modules
195+
monitoring_modules.append(process.siPixelPhase1MonitorRawDataASerial)
196+
monitoring_modules.append(process.siPixelPhase1MonitorRawDataADevice)
197+
monitoring_modules.append(process.siPixelPhase1CompareDigiErrorsSoAAlpaka)
198+
199+
if doRecHits:
200+
monitoring_modules.append(process.siPixelRecHitsSoAMonitorDevice)
201+
monitoring_modules.append(process.siPixelRecHitsSoAMonitorSerial)
202+
monitoring_modules.append(process.siPixelPhase1CompareRecHits)
203+
204+
if doTracks:
205+
monitoring_modules.append(process.siPixelTrackSoAMonitorDevice)
206+
monitoring_modules.append(process.siPixelTrackSoAMonitorSerial)
207+
monitoring_modules.append(process.siPixelPhase1CompareTracks)
208+
209+
if doVertices:
210+
monitoring_modules.append(process.siPixelVertexSoAMonitorDevice)
211+
monitoring_modules.append(process.siPixelVertexSoAMonitorSerial)
212+
monitoring_modules.append(process.siPixelCompareVertices)
213+
214+
# Always add the comparison harvesting sequence as before
215+
monitoring_modules.append(process.siPixelPhase1RawDataHarvesterSerial)
216+
monitoring_modules.append(process.siPixelPhase1RawDataHarvesterDevice)
217+
218+
if doTracks:
219+
monitoring_modules.append(process.siPixelTrackComparisonHarvesterAlpaka)
220+
221+
# Now create the path with those modules
222+
process.tasksPath = cms.Path()
223+
for mod in monitoring_modules:
224+
process.tasksPath *= mod
225+
226+
print(process.tasksPath)
227+
182228
#-------------------------------------
183229
# Pixel DQM Tasks/Clients Sequences Definition
184230
#-------------------------------------
185231

186-
process.tasksPath = cms.Path(process.monitorpixelSoACompareSourceAlpaka *
187-
process.siPixelHeterogeneousDQMComparisonHarvestingAlpaka)
232+
#process.tasksPath = cms.Path(process.monitorpixelSoACompareSourceAlpaka *
233+
# process.siPixelHeterogeneousDQMComparisonHarvestingAlpaka)
188234

189235
#-------------------------------------
190236
# Paths/Sequences Definitions

DQM/SiPixelHeterogeneous/python/SiPixelHeterogenousDQMHarvesting_cff.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828

2929
phase2_tracker.toReplaceWith(siPixelHeterogeneousDQMComparisonHarvestingAlpaka,_siPixelHeterogeneousDQMComparisonHarvestingAlpakaPhase2)
3030

31-
3231
# add the harvester in case of the validation modifier is active
3332
from Configuration.ProcessModifiers.gpuValidationPixel_cff import gpuValidationPixel
3433
gpuValidationPixel.toReplaceWith(siPixelHeterogeneousDQMHarvesting,siPixelHeterogeneousDQMComparisonHarvesting)

DQMOffline/Trigger/python/HeterogeneousMonitoringClient_cff.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,6 @@
44
from DQM.SiPixelHeterogeneous.siPixelTrackComparisonHarvester_cfi import *
55
hltSiPixelTrackComparisonHarvester = siPixelTrackComparisonHarvester.clone(topFolderName = 'HLT/HeterogeneousComparisons/PixelTracks')
66

7-
HLTHeterogeneousMonitoringHarvesting = cms.Sequence(hltSiPixelTrackComparisonHarvester)
7+
HLTHeterogeneousMonitoringHarvesting = cms.Sequence(
8+
hltSiPixelTrackComparisonHarvester
9+
)

DQMOffline/Trigger/python/HeterogeneousMonitoring_cff.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
HLTHeterogeneousMonitoringSequence = cms.Sequence(
9898
hltPfHcalGPUComparisonTask +
9999
hltSiPixelPhase1CompareDigiErrors +
100-
hltSiPixelPhase1CompareRecHits +
100+
#hltSiPixelPhase1CompareRecHits + # waiting a resolution of #49349
101101
hltSiPixelPhase1CompareTracks +
102102
hltSiPixelCompareVertices +
103103
hltEcalMonitorTask +

0 commit comments

Comments
 (0)