Merge pull request #46321 from smuzaffar/reconstruction-clang-ana-warn2

[RECONSTRUCTION] [Clang]Cleanup clang-analyzer warnings

Author: cmsbuild

MagneticField/ParametrizedEngine/src/BFit3D.cc

@@ -9,7 +9,7 @@ using namespace magfieldparam;
 
 //_______________________________________________________________________________
 void BFit3D::SetCoeff_Linear(const double B) {
-  unsigned jj, kk = 1;
+  unsigned jj;
   double w_0, w_1, B_mod = fabs(B);
   if (B_mod <= B_nom[0]) {
     w_0 = B / B_nom[0];
@@ -22,6 +22,8 @@ void BFit3D::SetCoeff_Linear(const double B) {
       C[jj] = w_0 * C0[jj][3];
     }
   } else {
+    unsigned kk = 1;
+    [[clang::suppress]]
     while (B_nom[kk] < B_mod)
       ++kk;  //Simple linear search
     w_1 = (B_mod - B_nom[kk - 1]) / (B_nom[kk] - B_nom[kk - 1]);
@@ -38,7 +40,7 @@ void BFit3D::SetCoeff_Linear(const double B) {
 
 //_______________________________________________________________________________
 void BFit3D::SetCoeff_Spline(const double B) {
-  int jc, k0 = 0, k1 = 1;
+  int jc;
   double dB2, dB = fabs(B);
   if (dB >= B_nom[3]) {  //Linear extrapolation for a large field
     dB -= B_nom[3];
@@ -50,9 +52,11 @@ void BFit3D::SetCoeff_Spline(const double B) {
       for (jc = 0; jc < 360; ++jc)
         C[jc] = (C2[jc][0] * dB2 + C1[jc][0]) * dB;
     } else {
+      int k1 = 1;
+      [[clang::suppress]]
       while (B_nom[k1] < dB)
         ++k1;  //Simple linear search
-      k0 = k1 - 1;
+      int k0 = k1 - 1;
       dB2 = (dB -= B_nom[k0]) / (3. * (B_nom[k1] - B_nom[k0]));
       if (k1 < 3) {  //"Regular" interval
         for (jc = 0; jc < 360; ++jc)

RecoJets/JetProducers/plugins/VirtualJetProducer.cc

@@ -686,7 +686,7 @@ void VirtualJetProducer::writeJets(edm::Event& iEvent, edm::EventSetup const& iS
     // Distance between jet centers and overlap area -- for disk-based area calculation
     using RIJ = std::pair<double, double>;
     std::vector<RIJ> rijStorage(fjJets_.size() * (fjJets_.size() / 2));
-    RIJ* rij[fjJets_.size()];
+    std::vector<RIJ*> rij(fjJets_.size());
     unsigned int k = 0;
     for (unsigned int ijet = 0; ijet < fjJets_.size(); ++ijet) {
       rij[ijet] = &rijStorage[k];
@@ -752,11 +752,10 @@ void VirtualJetProducer::writeJets(edm::Event& iEvent, edm::EventSetup const& iS
         // Here it is assumed that fjJets_ is in decreasing order of pT,
         // which should happen in FastjetJetProducer::runAlgorithm()
         jetArea = M_PI;
-        //rij is properly initialized above
-        [[clang::suppress]]
         RIJ* distance = rij[ijet];
         for (unsigned jJet = 0; jJet < ijet; ++jJet) {
-          distance[jJet].first = std::sqrt(reco::deltaR2(etaJ[ijet], phiJ[ijet], etaJ[jJet], phiJ[jJet])) * orParam_;
+          [[clang::suppress]] distance[jJet].first =
+              std::sqrt(reco::deltaR2(etaJ[ijet], phiJ[ijet], etaJ[jJet], phiJ[jJet])) * orParam_;
           distance[jJet].second = reco::helper::VirtualJetProducerHelper::intersection(distance[jJet].first);
           jetArea -= distance[jJet].second;
           for (unsigned kJet = 0; kJet < jJet; ++kJet) {

RecoLuminosity/TCPReceiver/src/TCPReceiver.cc

@@ -28,6 +28,7 @@
 #include <netdb.h>
 
 #include <cstring>
+#include <cassert>
 
 namespace HCAL_HLX {
 
@@ -121,7 +122,7 @@ namespace HCAL_HLX {
         memset(BigBuffer, 0, bytesToReceive);
 
         usleep(10000);
-
+        assert(tcpSocket >= 0);
         while ((totalBytesRcvd < bytesToReceive) && (errorCode == 0)) {
           SetupFDSets(fdsRead, fdsWrite, fdsExcept, -1, tcpSocket);
 

RecoTracker/MkFitCore/src/MatriplexPackers.h

@@ -94,6 +94,7 @@ namespace mkfit {
 
     template <typename TMerr, typename TMpar>
     void pack(TMerr& err, TMpar& par) {
+      assert(this->m_base);
       assert(this->m_pos > 0 && this->m_pos <= NN);
 
 #if defined(GATHER_INTRINSICS)