PPS: no geometry specification in reco cff files

[jan-kaspar]

It has been recommended to PPS to remove geometry specifications from reco cff files, see e.g.

• Port CTPPS to DD4hep #31240 (comment)
• Port CTPPS to DD4hep #31240 (comment)

[cmsbuild]

A new Issue was created by @jan-kaspar .

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[jan-kaspar]

FYI @makortel @davidlange6

[jan-kaspar]

@davidlange6 Who would be the right contacts from the geometry system to coordinate this work with?

[makortel]

assign geometry

[makortel]

Who would be the right contacts from the geometry system to coordinate this work with?

@cvuosalo (and @ianna )

[cmsbuild]

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jan-kaspar]

@cvuosalo and @ianna We (PPS) have been asked to remove geometry specifications from reco-related cff files, e.g. here:

cmssw/RecoPPS/Configuration/python/recoCTPPS_cff.py

Line 12 in 20a7acf

from Geometry.VeryForwardGeometry.geometryRPFromDB_cfi import *

and move them to a top-level config of the geometry system. Could you please suggest what a good destination could be? It was also mentioned that CMS supports different geometry sources (DB, XML files, ...). Do we need to take care of this, too? Many thanks in advance!

[cvuosalo]

@jan-kaspar I think the correct place for PPS reco geometry might be Configuration/Geometry/python/GeometryRecoDB_cff.py. XML and simulation geometry should be checked to be sure they include all needed PPS components. Additional cff files in Configuration/Geometry like GeometryReco_cff.py may need additions for PPS.

[jan-kaspar]

Thanks @cvuosalo ! What is the cff file for the "XML geometry" that you mention? What is the use of the "GeometryReco_cff.py"?

[jan-kaspar]

If you agreed, I would schedule this fix after the other ongoing geometry-related modifications by @ghugo83 and @forthommel - not to do to many things in parallel.