Merging CondCore small plugins in to one package

[smuzaffar]

Following the discussion in #40207, I am opening this issue. We have a lot of CondCode/*Plugins packages [a] in cmssw which just have one or two files and generate edmplugins. I would suggest to see if we can merge all of these in to one package. It is trivial to do from the build system point of view but I see there is at least one script cmscond_list_esrecord which looks in to the CondCode/*Plugins to find ES recodes. If this is the only code which uses the package structure then new package can have CondCode/EsRecords/plugins/Alignment/*.cc files and we fix the cmscond_list_esrecord script to look under CondCode/EsRecords/plugins/*/*.cc

[a]

AlignmentPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
BTauPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
BeamSpotPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
CSCPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
CTPPSPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
CalibPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
CastorPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
DQMPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
DTPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
ESPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
EcalPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
EgammaPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
GBRForestPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
GEMPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
HIPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
HLTPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
HcalPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
JetMETPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
L1TPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
LuminosityPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
OptAlignPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
PCLConfigPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
PhysicsToolsPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
RPCPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
RecoMuonPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
RunInfoPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>
SiPhase2TrackerPlugins/BuildFile.xml:<flags EDM_PLUGIN="1"/>

[cmsbuild]

A new Issue was created by @smuzaffar Malik Shahzad Muzaffar.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[smuzaffar]

assign core,db

[cmsbuild]

New categories assigned: core,db

@Dr15Jones,@smuzaffar,@ggovi,@makortel,@francescobrivio,@malbouis,@saumyaphor4252,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

[smuzaffar]

looks like https://github.com/cms-sw/cmssw/blob/master/CondCore/Utilities/scripts/cmscond_list_esrecord script is broken any way as it does not run under python3. So can any one explain how are these small CondCore plugin used and what will break if we merge these in one plugin?

[tvami]

So can any one explain how are these small CondCore plugin used and what will break if we merge these in one plugin?

It is used to map the ES records to their objects. Not really sure if merging would break anything until these files are compiled correctly.

[mmusich]

It is used to map the ES records to their objects. Not really sure if merging would break anything until these files are compiled correctly.

see also #40207 (comment).
IF a PR is prepared with the merging into one package, I'd recommend to test the branch in "DEMO" branch of the payload inspector.