[LLVM Analyzer] Called C++ object pointer is null in ConverterToTTTrack::makeTTTrack

[iarspider]

Analyzer report: link .

I guess lines 42-43 should be moved inside else branch, and phi0 and rinv should be initialized to zero (or some other constant value) around line 28

[iarspider]

assign L1Trigger/TrackFindingTMTT

[cmsbuild]

New categories assigned: l1

@epalencia,@aloeliger you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

On the other hand, trk not being L1fittedTrack (i.e. the dynamic_cast failing in

cmssw/L1Trigger/TrackFindingTMTT/src/ConverterToTTTrack.cc

Line 16 in 354a892

const L1fittedTrack* fitTrk = dynamic_cast<const L1fittedTrack*>(trk);

, the if branch) is different from trk being null in the first place. So I'd argue the static analyzer warning is strictly speaking incorrect (because trk can be non-null when fitTrk is null).

Written that, if trk can be null, the makeTTTrack() should check it before accessing it, and if tkr is never expected to be null, it should be passed as const reference instead of a pointer.

[dan131riley]

Frivolous question: what's with the const double& on 42-43,45. Surely those should be plain old const double.

[aloeliger]

@tomalin Could I ask you to take a look at this?