-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
The start_dev target is not useful. It runs bash inside a docker container, whic his easy enough to do by hand. It's also unclear which docker container it's actually trying to use.
The target runs the ghcr.io/cmu-delphi/forecast-eval image, which is meant for the dashboard, but mounts the Report and dist dirs that are only needed to run the pipeline, not the dashboard.
Three options here:
- Remove all
makesupport for runningbashin containers. Let devs do that themselves if they need to. - Make
start_devrunbashin the dashboard container only, i.e. drop pipeline dependencies. Set up another target to runbashin the pipelineforecast-eval-buildimage. - Set up a variable that by default runs the dashboard or pipeline in their respective containers (
start_dashboardandscore_forecast), but can be overridden through themakecall to runbashin each container.
Metadata
Metadata
Assignees
Labels
No labels