Custom disassembler warning message incorrectly displays on x86 disassembler

[edmcman]

root@fd44a08dfb74:/# fn2hash -j - --option pharos.disassembler=amd64 map:0x1000::/etc/passwd
OPTI[INFO ]: Analyzing executable: 4AF514F469681E8C80D215898ED47E17
OPTI[INFO ]: Calculating function hashes for file: 4AF514F469681E8C80D215898ED47E17 ; MD5: 4AF514F469681E8C80D215898ED47E17
OPTI[WARN ]: Using rose partitioner instead of pharos partitioner due to non-i386 disassembler
OPTI[INFO ]: Pharos function partitioning took 0.000113175 seconds.
OPTI[INFO ]: Partitioned 0 bytes, 0 instructions, 0 basic blocks, 0 data blocks and 0 functions.
HASH[ERROR]: No starting points for recursive disassembly.
OPTI[INFO ]: fn2hash complete
{"analysis": [],"analyzed_file": "map:0x1000::/etc/passwd","invocation": ["fn2hash","-j","-","--option","pharos.disassembler=amd64","map:0x1000::/etc/passwd"],"tool": "fn2hash"}

The code at

pharos/libpharos/descriptors.cpp

Line 296 in 1a4d4b9

if (arch && std::dynamic_pointer_cast<Rose::BinaryAnalysis::Architecture::X86>(*arch)) {

looks right to me at first glance.

http://rosecompiler.org/ROSE_HTML_Reference/classRose_1_1BinaryAnalysis_1_1Architecture_1_1X86.html

[sei-mwd]

Looks like there's a missing ! in that line before the dynamic_cast.

[sei-eschwartz]

Note to self, don't read code before coffee.

…

________________________________________ From: Michael Duggan ***@***.***> Sent: Tuesday, April 1, 2025 10:00 AM To: cmu-sei/pharos Cc: Subscribed Subject: Re: [cmu-sei/pharos] Custom disassembler warning message incorrectly displays on x86 disassembler (Issue #281) Warning: External Sender - do not click links or open attachments unless you recognize the sender and know the content is safe. Looks like there's a missing ! in that line before the dynamic_cast. — Reply to this email directly, view it on GitHub<#281 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL6ZAVF5KM6LLOHTKN6ZBZD2XKLXBAVCNFSM6AAAAAB2G4C7DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZGQ3DAOBSG4>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [sei-mwd]sei-mwd left a comment (cmu-sei/pharos#281)<#281 (comment)> Looks like there's a missing ! in that line before the dynamic_cast. — Reply to this email directly, view it on GitHub<#281 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL6ZAVF5KM6LLOHTKN6ZBZD2XKLXBAVCNFSM6AAAAAB2G4C7DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZGQ3DAOBSG4>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>