Update the check before coalesce more robust (#42)

dkatzz · web-flow · commit 596f57a062cd · 2025-09-05T15:44:53.000+01:00
diff --git a/main.tf b/main.tf
@@ -16,7 +16,7 @@ resource "aws_cloudwatch_metric_alarm" "cpu_high" {
   }
   alarm_actions = compact([
     aws_appautoscaling_policy.scale_up_policy.arn,
-    var.sns_topic_arn != "" || var.high_cpu_sns_topic_arn != "" ? coalesce(var.sns_topic_arn, var.high_cpu_sns_topic_arn, "") : ""
+    (var.sns_topic_arn != "" && var.sns_topic_arn != null) || (var.high_cpu_sns_topic_arn != "" && var.high_cpu_sns_topic_arn != null) ? coalesce(var.sns_topic_arn, var.high_cpu_sns_topic_arn, "") : ""
   ])
   tags = var.tags
 }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ resource "aws_cloudwatch_metric_alarm" "cpu_high" {`
`16`	`16`	`}`
`17`	`17`	`alarm_actions = compact([`
`18`	`18`	`aws_appautoscaling_policy.scale_up_policy.arn,`
`19`		`- var.sns_topic_arn != "" \|\| var.high_cpu_sns_topic_arn != "" ? coalesce(var.sns_topic_arn, var.high_cpu_sns_topic_arn, "") : ""`
	`19`	`+ (var.sns_topic_arn != "" && var.sns_topic_arn != null) \|\| (var.high_cpu_sns_topic_arn != "" && var.high_cpu_sns_topic_arn != null) ? coalesce(var.sns_topic_arn, var.high_cpu_sns_topic_arn, "") : ""`
`20`	`20`	`])`
`21`	`21`	`tags = var.tags`
`22`	`22`	`}`