Skip to content

Commit 063e2e9

Browse files
committed
Xia shall error
1 parent 01e5cf4 commit 063e2e9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/ESP32.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,13 @@ jobs:
142142
fi
143143
if [ -n "${CAMERA_MODEL}" ]; then
144144
echo "FW_NAME=${CAMERA_MODEL}" >> $GITHUB_ENV
145-
make ${MAKE_CMD} CFLAGS_EXTRA="-DMP_CAMERA_MODEL_${CAMERA_MODEL}=1" all
145+
FINAL_CMD="make ${MAKE_CMD} CFLAGS_EXTRA=\"-DMP_CAMERA_MODEL_${CAMERA_MODEL}=1\" all"
146146
else
147147
echo "FW_NAME=${BUILD_TARGET}" >> $GITHUB_ENV
148-
make ${MAKE_CMD} all
148+
FINAL_CMD="make ${MAKE_CMD} all"
149149
fi
150+
echo "Running command: $FINAL_CMD"
151+
eval $FINAL_CMD
150152
mv ~/micropython/ports/esp32/build-${BUILD_TARGET}/firmware.bin ~/firmware.bin
151153
152154

src/camera_pins.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@
192192
#define MICROPY_CAMERA_PIN_PCLK 21
193193

194194
#elif defined(MP_CAMERA_MODEL_XIAO_ESP32S3)
195+
#error THIS IS A PLACEHOLDER FOR THE XIAO ESP32-S3 CAMERA PINOUT
195196
#define MICROPY_CAMERA_PIN_PWDN -1
196197
#define MICROPY_CAMERA_PIN_RESET -1
197198
#define MICROPY_CAMERA_PIN_XCLK 10

0 commit comments

Comments
 (0)