-
Notifications
You must be signed in to change notification settings - Fork 3
base: add twincat-ads module #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash 36dbfda in the one adding those lines.
You can rewrite your branch history to accomplish this.
|
Github dropped some of my review comments 🫠. Will try to remember then again. |
|
In 1a125c6: I think that this commit can be split in two: The first one adding the module and the second one adding the new IOC image. |
Add twincat-ads repository and separate modules from the example IOC. - Clone twincat-ads recursively to include the BeckhoffADS submodule (traditional download .tar.gz does not contain this submodule). - Split repository into two folders: - ads-modules: EPICS modules (libraries) - ads-ioc: minimal example IOC - The twincat-ads repo does not provide the standard IOC layout (configure/, Makefile, iocBoot/), so a minimal example IOC is generated with makeBaseApp.pl. - Copy compiled modules and startup scripts from ads-modules into ads-ioc to produce a buildable IOC and avoid EPICS build errors. This keeps the module sources intact while providing a consistent, EPICS-compatible IOC structure.
Add related files for the TwinCAT ADS IOC.
36dbfda to
b51566c
Compare
|
As we discussed in depth in person, we'd like to move forward a more generic and reusable manner of dealing with IOCs inside epics-in-docker; especially in this case where the upstream doesn't provide a standard example IOC. I'm marking this PR as draft until we can tackle such improvements (in another PR), which would be directly applicable for this module's IOC. |
Install twincat-ads separating modules and IOC