chore(smoke-nuke): disassociate AppRegistry resources before delete

First nuke run left two AppRegistry apps stuck:

  ValidationException: Disassociate all resources before you delete
  application NDXTry_BOPS_Planning_464453619983

The app's CFN AppRegistryAssociation resource gets gc'd when the
nested stack dies but the AppRegistry-side association lingers. Add a
list-associated-resources + disassociate-resource loop per app before
the delete-application call.

Author: chrisns

scripts/smoke-nuke.sh

@@ -197,6 +197,22 @@ if [ -z "$apps" ]; then
 else
   while IFS= read -r app; do
     [ -z "$app" ] && continue
+    # AppRegistry refuses delete while resources are associated.
+    # Disassociate every resource type listed under the app, then delete.
+    echo "disassociating resources for: $app"
+    assoc=$(aws servicecatalog-appregistry list-associated-resources \
+      --application "$app" \
+      --query 'resources[].[arn,resourceType]' \
+      --output text 2>/dev/null | grep -v '^$' || true)
+    if [ -n "$assoc" ]; then
+      while IFS=$'\t' read -r arn rtype; do
+        [ -z "$arn" ] && continue
+        echo "  disassociate $rtype: $arn"
+        aws servicecatalog-appregistry disassociate-resource \
+          --application "$app" --resource-type "$rtype" --resource "$arn" \
+          2>&1 | sed 's/^/    /' || true
+      done <<< "$assoc"
+    fi
     echo "delete appregistry: $app"
     aws servicecatalog-appregistry delete-application --application "$app" 2>&1 | sed 's/^/    /' || true
   done <<< "$apps"