Skip to content

Commit dc66cb8

Browse files
authored
Merge pull request #397 from co-cddo/chore/role-chaining
fix(ci-lease): chained-assume session capped at 1h
2 parents 2dfe72a + 48d8a8c commit dc66cb8

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/scenario-ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,12 @@ jobs:
101101
role-to-assume: arn:aws:iam::${{ steps.lease.outputs.account_id }}:role/InnovationSandbox-ndx-CIDeployRole
102102
role-session-name: scenario-ci-deploy-${{ github.run_id }}
103103
aws-region: us-east-1
104-
role-duration-seconds: 21600
104+
# Chained assumes (sigv4 from already-assumed creds) are capped
105+
# at 1h by AWS regardless of MaxSessionDuration on the target
106+
# role. Asking for more returns ValidationError. Workflow job
107+
# timeout is 90m so any deploy needing >1h would already need
108+
# other plumbing.
109+
role-duration-seconds: 3600
105110
role-chaining: true
106111
# The default session-tag attempt requires sts:TagSession in the
107112
# target role's trust policy, which CIDeployRole doesn't grant.

0 commit comments

Comments
 (0)