Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilenameBear.py: Move relevant code lines #1995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naivedyabansal
Copy link

@naivedyabansal naivedyabansal commented Aug 13, 2017

Moves conditional statement to requisite position.

Fixes #1846

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Moves conditional statement to requisite position.

Fixes coala#1846
@Nosferatul
Copy link
Member

ack ff918d4

@Nosferatul
Copy link
Member

please rebase it 👍 and LGTM

Copy link
Member

@khanchi97 khanchi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack ff918d4

@SanketDG
Copy link
Member

needs rebase

@tanhengyeow
Copy link
Member

You can follow this guide for rebasing :)

@pranavmodx
Copy link

Looks like @naivedyabansal is not working on this issue anymore (rebasing). Can I take it up as my first newcomer issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

FilenameBear: Move code
7 participants