nics: Improve dialogs with new framework components

 - Use DialogRadioSelect, use it for "Type" and "Mode"

 - Change TypeAndSource to disable types without sources instead of
   disabling the sources selector.

 - When editing a interface, always include the current source in the
   choices, even if it doesn't actually exist.

 - When adding, re-create "default" network when none other exists to
   always have a path through the dialog.

Author: mvollmer

src/components/vm/nics/create-default-network.sh

@@ -0,0 +1,26 @@
+#! /bin/sh
+
+set -e
+
+# See https://wiki.libvirt.org/Networking.html#host-configuration-nat
+
+f=/usr/share/libvirt/networks/default.xml
+if test -f "$f"; then
+    virsh -c qemu:///system net-define "$f"
+else
+    cat <<EOF | virsh -c qemu:///system net-define /dev/stdin
+<network>
+  <name>default</name>
+  <bridge name='virbr0'/>
+  <forward/>
+  <ip address='192.168.122.1' netmask='255.255.255.0'>
+    <dhcp>
+      <range start='192.168.122.2' end='192.168.122.254'/>
+    </dhcp>
+  </ip>
+</network>
+EOF
+fi
+
+virsh -c qemu:///system net-autostart default
+virsh -c qemu:///system net-start default

src/components/vm/nics/create-default-network.sh.d.ts

@@ -0,0 +1,2 @@
+declare const content: string;
+export default content;

src/components/vm/nics/nicAdd.tsx

@@ -23,7 +23,6 @@ import { useDialogs } from 'dialogs';
 import type { VM } from '../../../types';
 import type { AvailableSources } from './vmNicsCard';
 
-import { Checkbox } from "@patternfly/react-core/dist/esm/components/Checkbox";
 import { Form, FormGroup } from "@patternfly/react-core/dist/esm/components/Form";
 import {
     Modal, ModalBody, ModalFooter, ModalHeader
@@ -32,8 +31,7 @@ import { Radio } from "@patternfly/react-core/dist/esm/components/Radio";
 import { TextInput } from "@patternfly/react-core/dist/esm/components/TextInput";
 
 import {
-    NetworkTypeAndSourceValue, NetworkTypeAndSourceRow,
-    init_NetworkTypeAndSourceRow, validate_NetworkTypeAndSourceRow,
+    NetworkTypeAndSourceValue, NetworkTypeAndSourceRow, init_NetworkTypeAndSourceRow,
     NetworkModelRow,
     PortForwardsValue, NetworkPortForwardsRow, validate_PortForwards,
     dialogPortForwardsToInterface,
@@ -44,9 +42,12 @@ import { AppState } from '../../../app';
 import {
     useDialogState, DialogValue, DialogError,
     DialogErrorMessage, DialogHelperText,
-    DialogActionButton, DialogCancelButton
+    DialogActionButton, DialogCancelButton,
+    DialogCheckbox,
 } from '../../common/dialog';
 
+import create_default_network_sh from "./create-default-network.sh";
+
 import './nic.css';
 
 const _ = cockpit.gettext;
@@ -143,18 +144,11 @@ const PermanentChange = ({
     // down only. Enable permanent change of the domain.xml
 
     return (
-        <FormGroup
-            fieldId={value.id()}
-            label={_("Persistence")}
-            hasNoPaddingTop
-        >
-            <Checkbox
-                id={value.id()}
-                isChecked={value.get()}
-                label={_("Always attach")}
-                onChange={(_event, checked) => value.set(checked)}
-            />
-        </FormGroup>
+        <DialogCheckbox
+            field_label={_("Persistence")}
+            checkbox_label={_("Always attach")}
+            value={value}
+        />
     );
 };
 
@@ -191,7 +185,6 @@ export const AddNIC = ({
 
     function validate() {
         validate_NetworkMacRow(dlg.value("mac"));
-        validate_NetworkTypeAndSourceRow(dlg.value("type_and_source"));
         if (dlg.values.type_and_source.type == "user")
             validate_PortForwards(dlg.value("portForwards"));
     }
@@ -217,6 +210,10 @@ export const AddNIC = ({
             let backend = null;
             if (tas.type == "user" && vm.capabilities.interfaceBackends.includes("passt"))
                 backend = "passt";
+            if (source == "$create") {
+                await cockpit.script(create_default_network_sh, [], { err: "message", superuser: "try" });
+                source = "default";
+            }
             await virtXmlHotAdd(
                 vm,
                 "network",