Skip to content

Commit 4db8344

Browse files
ci,docs: remove bors references after switch to trunk merge queue (#166170)
ci,docs: remove bors references after switch to trunk merge queue
2 parents 974fa0a + b037b98 commit 4db8344

File tree

7 files changed

+12
-52
lines changed

7 files changed

+12
-52
lines changed

.github/bors.toml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.trunk/trunk.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
# Trunk configuration file
2-
# This configuration replicates the bors.toml settings for merge queue functionality
32

43
version: 0.1
54

65
# CLI configuration
76
cli:
87
version: 1.22.2
98

10-
# Merge queue configuration (equivalent to bors.toml)
9+
# Merge queue configuration
1110
merge:
1211
# Use Trunk's merge queue service
1312
service: queue

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ change, as they can cause merge conflicts in ongoing development.
2525
commit message is the primary record, not the PR description.
2626
Include release note annotations.
2727
7. Push and [create a PR](https://help.github.com/articles/creating-a-pull-request).
28-
8. Merge via `bors r+` (not the green button).
28+
8. Merge via the merge queue.
2929

3030
## Code Review
3131

build/teamcity-support.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,9 @@ tc_release_branch() {
266266
[[ "$branch" == master || "$branch" == release-* || "$branch" == provisional_* || "$branch" == "staging-"* ]]
267267
}
268268

269-
tc_bors_branch() {
269+
is_trunk_branch() {
270270
branch=$(tc_build_branch)
271-
[[ "$branch" == staging ]]
271+
[[ "$branch" == trunk-merge/* ]]
272272
}
273273

274274
if_tc() {

build/teamcity/cockroach/ci/tests-aws-linux-arm64-bigvm/unit_tests_impl.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ bazel build //pkg/cmd/bazci
1616

1717
EXTRA_PARAMS=""
1818

19-
if tc_bors_branch; then
20-
# enable up to 1 retry (2 attempts, worst-case) per test executable to report flakes but only on release branches and staging.
19+
if tc_release_branch || is_trunk_branch; then
20+
# enable up to 1 retry (2 attempts, worst-case) per test executable to report flakes on release/trunk branches.
2121
EXTRA_PARAMS=" --flaky_test_attempts=2"
2222
fi
2323

build/teamcity/cockroach/ci/tests/testrace.sh

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,16 @@ dir="$(dirname $(dirname $(dirname $(dirname $(dirname "${0}")))))"
1313
source "$dir/teamcity-support.sh" # For $root, changed_go_pkgs
1414
source "$dir/teamcity-bazel-support.sh" # For run_bazel
1515

16-
# The full race suite takes >4h and is only suitable for nightlies. On master
17-
# and staging, run just the `server` package which (at the time of writing)
16+
# The full race suite takes >4h and is only suitable for nightlies. On release
17+
# branches, run just the `server` package which (at the time of writing)
1818
# takes <30m to run and exercises most of the code in the system at least
19-
# rudimentarily. This (hopefully) causes obvious races to fail in bors,
19+
# rudimentarily. This (hopefully) causes obvious races to fail early,
2020
# before spraying failures over the nightly stress suite.
2121
canaryspec=./pkg/server
2222
tc_start_block "Determine changed packages"
23-
if tc_release_branch; then
23+
if tc_release_branch || is_trunk_branch; then
2424
pkgspec="${canaryspec}"
25-
echo "On release branch ($TC_BUILD_BRANCH), so running canary testrace ($pkgspec)"
26-
elif tc_bors_branch; then
27-
pkgspec="${canaryspec}"
28-
echo "On bors branch ($TC_BUILD_BRANCH), so running canary testrace ($pkgspec)"
25+
echo "On release/trunk branch ($TC_BUILD_BRANCH), so running canary testrace ($pkgspec)"
2926
else
3027
pkgspec=$(changed_go_pkgs)
3128
if [[ $(echo "$pkgspec" | wc -w) -gt 10 ]]; then

docs/backporting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,4 @@ If Blathers was unable to automatically create a backport PR, follow these steps
7070
2. If there were any non-trivial merge conflicts, be sure to call those out in the PR message so reviewers can pay closer attention to the diff.
7171
3. If something goes wrong, you can use `backport --abort` to give up on the current manual backport.
7272

73-
Note: **You do not need to use bors** to merge a backport PR; just hit the big green button once the CI is green and the backport is approved by the reviewer (usually the main reviewer of the original PR to `master` branch). But note that if the backport has been open and unmerged for many days, CI results could be stale, and might not reflect the current state of the release branch. If the backport has been open and unmerged for many days, be sure to **rebase the backport PR on the tip of the release branch before merging** to get an up-to-date CI run.
73+
Note: Some release branches may have the Trunk merge queue enabled. If so, use the merge queue to merge the backport PR. Otherwise, just hit the big green button once the CI is green and the backport is approved by the reviewer (usually the main reviewer of the original PR to `master` branch). But note that if the backport has been open and unmerged for many days, CI results could be stale, and might not reflect the current state of the release branch. If the backport has been open and unmerged for many days, be sure to **rebase the backport PR on the tip of the release branch before merging** to get an up-to-date CI run.

0 commit comments

Comments
 (0)