Testing: Proper cleanup affer test-in-svsm.sh

[osteffenrh]

Then running test-in-svsm.sh from an interactive shell, there can be a QEMU process left behind running in the background. See #1050 (comment) and following comments.

A solution could be to only change terminal settings if running launch_guest.sh interactively (aka not from a script).

[n-ramacciotti]

This is a continuation of the conversation from the PR:

Adding exec seems to make it work, but there is a problem
about restoring the original interrupt from ctrl-] to ctrl-C
when launching test-in-svsm.sh directly, as it will remain
ctrl-] after execution.

But in the "test-in-svsm" case, where we use the timeout, we do not need the remapping of Ctrl+c, since this is not meant to be an interactive experience. We could skip changing the termnial settings when running launch_guest.sh in "testing" mode?

That makes more sense than what I was proposing (resetting it in test-in-svsm.sh)

We need the --foreground option AFAIK

I introduced foreground to run test-in-svsm locally and being able to interrupt it even before timeout. I'm not sure about other ways to keep the interrupt

edit: < /dev/null is needed otherwise qemu hangs waiting stdin that is not available since timeout is now running it in background

(without --foreground) I think launch-guest.sh stops before launching qemu here (tested with some echo before and after):

  stty intr ^]

edit: it actually stops also in qemu.

[n-ramacciotti]

A solution could be to only change terminal settings if running launch_guest.sh interactively (aka not from a script).

With the introduction of the monitor in #1084, it is possible to directly use exec in launch guest during tests (as you proposed here) without changes to the terminal settings