Frame rate is not accurate if it is set to 60 or higher on Android

[minggo]

Current implementation of FPS controller codes are

public void onDrawFrame(final GL10 gl) {
        /*
         * No need to use algorithm in default(60 FPS) situation,
         * since onDrawFrame() was called by system 60 times per second by default.
         */
        if (sAnimationInterval <= 1.0 / 60 * Cocos2dxRenderer.NANOSECONDSPERSECOND) {
            // when FPS is set to 60 or higher, not FPS controlling
            Cocos2dxRenderer.nativeRender();
        } else {
            // fps control codes
        }
    }

There is not doc says onDrawFrame is invoked 60 per second. So if onDrawFrame is invoked more than 60 per second and sAnimationInterval < 1.0 / 60 * Cocos2dxRenderer.NANOSECONDSPERSECOND, then there is not FPS controlling, which may make real FPS is more than 60.

[minggo]

onDrawFrame is invoked 60 per second when vsync is enabled.

[ijm700]

@minggo how do you recommend we fix this ? or is cocos team already working on it

[minggo]

I think we can just remove the codes of if statement to have a try. I will work on it after releasing v3.14.

[ijm700]

ok will this have any effect on my game play if I release to android or should I wait for new update ? @ricardoquesada any recommendations?

[minggo]

I think it will not affect your game too much, it just prevent to run too fast on devices that has high performance and invoke onDrawFrame more than 60 per second.

[minggo]

devices that has high performance and invoke onDrawFrame more than 60 per second

I haven't found such a device myself.

[ijm700]

okay, but isn't that a good thing that it doesn't let it go more than 60 fps ? I thought thats how it was supposed to be ?

[ijm700]

because if it goes more than 60 fps it could not be good for game play if you built it for 60 fps

[ijm700]

http://discuss.cocos2d-x.org/t/too-many-fps-in-android-device/8629/6 something like this could possibly happen

[minggo]

Yep, that's why i create this issue.

[ijm700]

Hey @minggo I found out some new info on this, the issue seems to be with samsung galaxy ace devices running 2.3 as the user from the cocos2dx was using and in this article below that I found.

http://gamedev.stackexchange.com/questions/90317/capping-framerate-independently-of-logic-updates-in-single-threaded-android-game

after looking around more I found this article below, and it also was with android 2.3 and it says that this was fixed with "project butter" that android did in android version 4.1 when they fixed vsync to not go more than 60 fps.

http://stackoverflow.com/questions/17652975/android-2-3-how-to-reduce-fps-to-60-vsync

So this issue is only on devices lower than 4.1 and android already stopped supporting 2.3 so I think it is safe to close this issue now let me know what you think ?

[ijm700]

https://nayaneshguptetechstuff.wordpress.com/2014/07/01/what-is-vsyc-in-android/ this article also references it