From 56fe59e8a2ea5a9e9326ef785ca0f4dd06a88963 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sat, 31 Aug 2024 18:45:26 +0000 Subject: [PATCH 01/22] fixed intervals --- cdx_toolkit/myrequests.py | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index 9127fbc..ad70cc0 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -7,13 +7,15 @@ LOGGER = logging.getLogger(__name__) - previously_seen_hostnames = { 'commoncrawl.s3.amazonaws.com', 'data.commoncrawl.org', 'web.archive.org', } +next_fetch = time.time() +minimum_interval = 3.0 # seconds + def dns_fatal(url): '''We have a dns error, should we fail immediately or not?''' @@ -23,6 +25,13 @@ def dns_fatal(url): def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): + t = time.time() + global next_fetch + if t < next_fetch: + time.sleep(next_fetch - t) + # next_fetch is also updated at the bottom + next_fetch = next_fetch + minimum_interval + if params: if 'from_ts' in params: params['from'] = params['from_ts'] @@ -38,8 +47,8 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): headers['User-Agent'] = 'pypi_cdx_toolkit/'+__version__ retry = True - retry_sec = 1 - retry_max_sec = 30 + retry_sec = 2 * minimum_interval + retry_max_sec = 60 retries = 0 connect_errors = 0 while retry: @@ -62,14 +71,10 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): # I have never seen IA or CC send 429 or 509, but just in case... # 429 is also a slow down, IA started sending them mid-2023 retries += 1 - if retries > 5: - LOGGER.warning('retrying after 1s for %d', resp.status_code) - if resp.text: - LOGGER.warning('response body is %s', resp.text) - else: - LOGGER.info('retrying after 1s for %d', resp.status_code) - if resp.text: - LOGGER.info('response body is %s', resp.text) + level = 30 if retries > 5 else 20 # 30=warning 20=info + LOGGER.log(level, 'retrying after %.2fs for %d', retry_sec, resp.status_code) + if resp.text: + LOGGER.log(level, 'response body is %s', resp.text) time.sleep(retry_sec) retry_sec = min(retry_sec*2, retry_max_sec) continue @@ -93,8 +98,8 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): raise ValueError(string) if connect_errors > 10: LOGGER.warning(string) - LOGGER.info('retrying after 1s for '+str(e)) - time.sleep(retry_sec) + LOGGER.info('retrying after {:.2f}s for '.format(retry_max_sec)+str(e)) + time.sleep(retry_max_sec) # notice the extra-long sleep retry_sec = min(retry_sec*2, retry_max_sec) except requests.exceptions.RequestException as e: # pragma: no cover LOGGER.warning('something unexpected happened, giving up after %s', str(e)) @@ -104,4 +109,7 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): if hostname not in previously_seen_hostnames: previously_seen_hostnames.add(hostname) + # in case we had a lot of retries, etc + next_fetch = time.time() + minimum_interval + return resp From 93216a3c00c53b51df0c77122f288ad4728335a4 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sat, 31 Aug 2024 20:11:15 +0000 Subject: [PATCH 02/22] revive CI --- .github/workflows/ci.yaml | 62 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 .github/workflows/ci.yaml diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml new file mode 100644 index 0000000..14512f4 --- /dev/null +++ b/.github/workflows/ci.yaml @@ -0,0 +1,62 @@ +name: CI + +on: + push: + branches: + - master + pull_request: + +jobs: + unit-tests: + runs-on: ${{ matrix.os }} + strategy: + fail-fast: false + matrix: + python-version: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] + os: [ubuntu-latest] + EXTRA: [false] # used to force includes to get included + include: + - python-version: '3.12' + os: ubuntu-latest + EXTRA: true + env: + LOGLEVEL=DEBUG + - python-version: '3.11' + os: macos-latest + EXTRA: true + - python-version: '3.12' + os: macos-latest + EXTRA: true + - python-version: '3.7' + os: windows-latest + EXTRA: true + - python-version: '3.12' + os: windows-latest + EXTRA: true + - python-version: '3.7' + os: ubuntu-20.04 # oldest version on github actions + EXTRA: true + + steps: + - name: checkout + uses: actions/checkout@v4 + + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + + - name: Install setuptools on python 3.12+ + if: ${{ matrix.python-version >= '3.12' }} + run: | + pip install setuptools + + - name: Install cdx_toolkit + run: pip install .[testing] + + - name: Run tests + run: | + make test_coverage + + - name: Upload coverage to Codecov + uses: codecov/codecov-action@v4 From 31fb53ab090341f3a28d78043a7d50b3324ce28a Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sat, 31 Aug 2024 20:15:45 +0000 Subject: [PATCH 03/22] revive CI --- .github/workflows/ci.yaml | 4 ++-- setup.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 14512f4..b2bfe5d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,7 +12,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] + python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest] EXTRA: [false] # used to force includes to get included include: @@ -52,7 +52,7 @@ jobs: pip install setuptools - name: Install cdx_toolkit - run: pip install .[testing] + run: pip install .[test] - name: Run tests run: | diff --git a/setup.py b/setup.py index cbdb0c7..bceaefb 100755 --- a/setup.py +++ b/setup.py @@ -12,7 +12,7 @@ # remember: keep requires synchronized with requirements.txt requires = ['requests', 'warcio'] -test_requirements = ['pytest', 'pytest-cov', 'coveralls'] +test_requirements = ['pytest', 'pytest-cov'] package_requirements = ['twine', 'setuptools', 'setuptools-scm'] @@ -37,7 +37,7 @@ author_email='lindahl@pbm.com', url='https://github.com/cocrawler/cdx_toolkit', packages=packages, - python_requires=">=3.6", + python_requires=">=3.7", extras_require=extras_require, setup_requires=['setuptools-scm'], install_requires=requires, @@ -59,7 +59,7 @@ 'License :: OSI Approved :: Apache Software License', 'Programming Language :: Python', #'Programming Language :: Python :: 3.5', # setuptools-scm problem - 'Programming Language :: Python :: 3.6', + #'Programming Language :: Python :: 3.6', # not offered in github actions 'Programming Language :: Python :: 3.7', 'Programming Language :: Python :: 3.8', 'Programming Language :: Python :: 3.9', From 34e05b295f8d0cd0a8034d3f0e46459f3457f523 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sat, 31 Aug 2024 20:37:50 +0000 Subject: [PATCH 04/22] revive ci --- .github/workflows/ci.yaml | 2 ++ cdx_toolkit/myrequests.py | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b2bfe5d..43a9369 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -60,3 +60,5 @@ jobs: - name: Upload coverage to Codecov uses: codecov/codecov-action@v4 + with: + token: ${{ secrets.CODECOV_TOKEN }} diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index 9127fbc..841de66 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -45,6 +45,7 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): while retry: try: LOGGER.debug('getting %s %r', url, params) + time.sleep(3) resp = requests.get(url, params=params, headers=headers, timeout=(30., 30.), allow_redirects=False) if cdx and resp.status_code in {400, 404}: From 72f93254d9aa43df8473df0591facd93b2a75ef7 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sat, 31 Aug 2024 20:38:50 +0000 Subject: [PATCH 05/22] revive ci --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 43a9369..b46d1af 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -11,6 +11,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: fail-fast: false + max-parallel: 1 matrix: python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest] From 6c3aec459180cb7f7d2152641d61d4e1d34ab2e4 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 00:48:29 +0000 Subject: [PATCH 06/22] chore: skip ia while working on ratelimits --- tests/test_cli.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/test_cli.py b/tests/test_cli.py index a69f922..8d42bc7 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -103,6 +103,7 @@ def test_multi_cc2(capsys, caplog): multi_helper(t, capsys, caplog) +@pytest.mark.skip(reason='needs some ratelimit love XXX') def test_multi_ia(capsys, caplog): tests = [ [{'service': '--ia', 'mods': '--limit 10', 'cmd': 'iter', 'rest': 'commoncrawl.org/*'}, @@ -146,6 +147,9 @@ def test_multi_rest(capsys, caplog): ] for t in tests: + if t[0]['service'] == '--ia': + # XXX skip + continue multi_helper(t, capsys, caplog) @@ -163,6 +167,9 @@ def test_warc(tmpdir, caplog): with tmpdir.as_cwd(): for p in prefixes: + if '--ia' in p or 'archive.org' in p: + # XXX skip + continue cmdline = p + base print(cmdline, file=sys.stderr) args = cmdline.split() @@ -182,6 +189,7 @@ def one_ia_corner(tmpdir, cmdline): main(args=cmdline.split()) +@pytest.mark.skip(reason='needs some ratelimit love XXX') def test_warc_ia_corners(tmpdir, caplog): ''' To test these more properly, need to add a --exact-warcname and then postprocess. From 245c9aceb8e338c1ab8f4a213ece1d30db2d7951 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 01:06:58 +0000 Subject: [PATCH 07/22] revive ci --- cdx_toolkit/myrequests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index 841de66..d3ce230 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -45,7 +45,7 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): while retry: try: LOGGER.debug('getting %s %r', url, params) - time.sleep(3) + time.sleep(0.7) resp = requests.get(url, params=params, headers=headers, timeout=(30., 30.), allow_redirects=False) if cdx and resp.status_code in {400, 404}: From 1cc6e1789c9ceeac49c0e8f9f314f263de2ffdc4 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 01:07:16 +0000 Subject: [PATCH 08/22] revive ci --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b46d1af..d93cf98 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -11,7 +11,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: fail-fast: false - max-parallel: 1 + #max-parallel: 1 matrix: python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest] From b160fb464c4772e27d20e749044106cbec3fa76c Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 03:00:54 +0000 Subject: [PATCH 09/22] revive ci --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index d93cf98..b46d1af 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -11,7 +11,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: fail-fast: false - #max-parallel: 1 + max-parallel: 1 matrix: python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest] From 0f821fa9176326e5557deb0b60407e74df328f75 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 03:40:47 +0000 Subject: [PATCH 10/22] revive ci --- tests/test_cli.py | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/tests/test_cli.py b/tests/test_cli.py index 8d42bc7..d3c3c05 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -122,7 +122,7 @@ def test_multi_ia(capsys, caplog): multi_helper(t, capsys, caplog) -def test_multi_rest(capsys, caplog): +def test_multi_misc_notia(capsys, caplog): tests = [ [{'service': '--source https://web.archive.org/cdx/search/cdx', 'mods': '--limit 10', 'cmd': 'iter', 'rest': 'commoncrawl.org/*'}, {'count': 10, 'linefgrep': 'commoncrawl.org'}], @@ -133,23 +133,29 @@ def test_multi_rest(capsys, caplog): [{'service': '--cc', 'mods': '--limit 10', 'cmd': 'size', 'rest': 'commoncrawl.org/*'}, {'count': 1, 'is_int': True}], - [{'service': '--ia', 'mods': '--limit 10', 'cmd': 'size', 'rest': 'commoncrawl.org/*'}, - {'count': 1, 'is_int': True}], [{'service': '--cc', 'mods': '--limit 10', 'cmd': 'size', 'rest': '--details commoncrawl.org/*'}, {'count': 2}], + + [{'service': '', 'mods': '--limit 10', 'cmd': 'iter', 'rest': 'commoncrawl.org/*'}, + {'exception': ValueError}], + ] + + for t in tests: + multi_helper(t, capsys, caplog) + + +@pytest.mark.skip(reason='needs some ratelimit love XXX') +def test_multi_misc_ia(capsys, caplog): + tests = [ + [{'service': '--ia', 'mods': '--limit 10', 'cmd': 'size', 'rest': 'commoncrawl.org/*'}, + {'count': 1, 'is_int': True}], [{'service': '--ia', 'mods': '--limit 10', 'cmd': 'size', 'rest': '--details commoncrawl.org/*'}, {'count': 2}], [{'service': '--ia', 'mods': '--from 20180101 --to 20180110 --limit 10', 'cmd': 'size', 'rest': '--details commoncrawl.org'}, {'count': 2}], - - [{'service': '', 'mods': '--limit 10', 'cmd': 'iter', 'rest': 'commoncrawl.org/*'}, - {'exception': ValueError}], ] for t in tests: - if t[0]['service'] == '--ia': - # XXX skip - continue multi_helper(t, capsys, caplog) From 081b68f0ebeb7da054ad3d371b442282700753a5 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 06:56:14 +0000 Subject: [PATCH 11/22] revive ci --- cdx_toolkit/myrequests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index d3ce230..f52253b 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -45,7 +45,7 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): while retry: try: LOGGER.debug('getting %s %r', url, params) - time.sleep(0.7) + time.sleep(3.0) # XXX resp = requests.get(url, params=params, headers=headers, timeout=(30., 30.), allow_redirects=False) if cdx and resp.status_code in {400, 404}: From 411c9c790d089d6f5110f19bf4b79c7ef1d383e0 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 08:52:50 +0000 Subject: [PATCH 12/22] revive ci --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b46d1af..bf0281e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -3,7 +3,7 @@ name: CI on: push: branches: - - master + - main pull_request: jobs: @@ -11,7 +11,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: fail-fast: false - max-parallel: 1 + #max-parallel: 1 matrix: python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] os: [ubuntu-latest] From 938faaec1ad4e3ddfaf2a493c7c5cea3ddbb0109 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 18:14:59 +0000 Subject: [PATCH 13/22] tweak retries --- cdx_toolkit/myrequests.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index ad70cc0..b0b4561 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -13,10 +13,6 @@ 'web.archive.org', } -next_fetch = time.time() -minimum_interval = 3.0 # seconds - - def dns_fatal(url): '''We have a dns error, should we fail immediately or not?''' hostname = urlparse(url).hostname @@ -24,6 +20,10 @@ def dns_fatal(url): return True +next_fetch = time.time() +minimum_interval = 3.0 # seconds + + def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): t = time.time() global next_fetch From bd7ccc188ff3c037602c1fcab3300c743f51dcca Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 20:25:06 +0000 Subject: [PATCH 14/22] new retry system based on rate limits --- cdx_toolkit/myrequests.py | 52 +++++++++++++++++++++++++++++++++------ 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index b0b4561..94fa726 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -13,24 +13,60 @@ 'web.archive.org', } -def dns_fatal(url): + +def dns_fatal(hostname): '''We have a dns error, should we fail immediately or not?''' - hostname = urlparse(url).hostname if hostname not in previously_seen_hostnames: return True -next_fetch = time.time() -minimum_interval = 3.0 # seconds +retry_info = { + 'default': { + 'next_fetch': 0, + 'minimum_interval': 3.0, + }, + 'index.commoncrawl.org': { + 'next_fetch': 0, + 'minimum_interval': 3.0, + }, + 'data.commoncrawl.org': { + 'next_fetch': 0, + 'minimum_interval': 3.0, + }, + 'web.archive.org': { + 'next_fetch': 0, + 'minimum_interval': 6.0, + }, +} + + +def get_retries(hostname): + if hostname not in retry_info: + retry_info[hostname] = retry_info['default'].copy() + LOGGER.debug('initializing retry info for new host '+hostname) + entry = retry_info[hostname] + if not entry['next_fetch']: + entry['next_fetch'] = time.time() + return entry['next_fetch'], entry['minimum_interval'] + + +def update_next_fetch(hostname, next_fetch): + retry_info[hostname]['next_fetch'] = next_fetch def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): t = time.time() - global next_fetch + + hostname = urlparse(url).hostname + next_fetch, minimum_interval = get_retries(hostname) + if t < next_fetch: - time.sleep(next_fetch - t) + dt = next_fetch - t + if dt > 3.1: + LOGGER.debug('sleeping for {:.3f}s before next fetch'.format(dt)) + time.sleep(dt) # next_fetch is also updated at the bottom - next_fetch = next_fetch + minimum_interval + update_next_fetch(hostname, next_fetch + minimum_interval) if params: if 'from_ts' in params: @@ -110,6 +146,6 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): previously_seen_hostnames.add(hostname) # in case we had a lot of retries, etc - next_fetch = time.time() + minimum_interval + update_next_fetch(hostname, time.time() + minimum_interval) return resp From 1d78e7614258a62000e3d021a26db93af93976ec Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 20:58:32 +0000 Subject: [PATCH 15/22] revive ci --- cdx_toolkit/myrequests.py | 1 - 1 file changed, 1 deletion(-) diff --git a/cdx_toolkit/myrequests.py b/cdx_toolkit/myrequests.py index 93bbd0f..94fa726 100644 --- a/cdx_toolkit/myrequests.py +++ b/cdx_toolkit/myrequests.py @@ -90,7 +90,6 @@ def myrequests_get(url, params=None, headers=None, cdx=False, allow404=False): while retry: try: LOGGER.debug('getting %s %r', url, params) - time.sleep(3.0) # XXX resp = requests.get(url, params=params, headers=headers, timeout=(30., 30.), allow_redirects=False) if cdx and resp.status_code in {400, 404}: From 7bbd409723c17753d58a491b20c24f4b65ff8cc0 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:08:13 +0000 Subject: [PATCH 16/22] revive ci --- .github/workflows/ci.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index bf0281e..3704101 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,10 +1,11 @@ name: CI on: - push: - branches: - - main - pull_request: + # runtime is erratic and up to an hour, so make this human-requested only + #push: + # branches: + # - main + #pull_request: jobs: unit-tests: From 47a3b25c28559798b51962a4e6c3886b5c9b81b4 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:09:21 +0000 Subject: [PATCH 17/22] revive ci --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3704101..6a7eb34 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,6 +1,6 @@ name: CI -on: +#on: # runtime is erratic and up to an hour, so make this human-requested only #push: # branches: From 03e4646301f2b566371fbafc2487007a18972902 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:23:08 +0000 Subject: [PATCH 18/22] revive ci --- .github/workflows/ci.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6a7eb34..c014a9d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,10 +1,10 @@ name: CI -#on: +on: # runtime is erratic and up to an hour, so make this human-requested only - #push: - # branches: - # - main + push: + branches: + - main #pull_request: jobs: From 022bd7f5e2ad7465ca576765f5f381a776ecb8e2 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:26:40 +0000 Subject: [PATCH 19/22] revive ci --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c014a9d..1dc4214 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -5,7 +5,9 @@ on: push: branches: - main - #pull_request: + pull_request: + branches: + - does_not_exist jobs: unit-tests: From 8cd62bcdde4d398424f0f24e30850fe26ebcb63e Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:33:53 +0000 Subject: [PATCH 20/22] revive ci --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1dc4214..c1739e0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -6,8 +6,8 @@ on: branches: - main pull_request: - branches: - - does_not_exist + branches-ignore: + - main jobs: unit-tests: From 0d7007f80f69e27d3ccbf7dfa98f94beaec0f637 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:45:23 +0000 Subject: [PATCH 21/22] revive ci --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c1739e0..e66c0fa 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -6,8 +6,10 @@ on: branches: - main pull_request: + branches: + - main branches-ignore: - - main + - main jobs: unit-tests: From 9a24378c42a25c871ffd5719c905dbfa9d3e7191 Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Sun, 1 Sep 2024 21:46:59 +0000 Subject: [PATCH 22/22] revive ci --- .github/workflows/ci.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e66c0fa..c78705e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,15 +1,13 @@ name: CI on: - # runtime is erratic and up to an hour, so make this human-requested only + # runtime is erratic and up to an hour push: branches: - main pull_request: branches: - main - branches-ignore: - - main jobs: unit-tests: