Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: Replace scalaj with sttp #496

Merged
merged 1 commit into from
Mar 25, 2024
Merged

clean: Replace scalaj with sttp #496

merged 1 commit into from
Mar 25, 2024

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Mar 25, 2024

No description provided.

@lolgab lolgab requested a review from DMarinhoCodacy March 25, 2024 13:48
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+9.55% (target: -1.00%) 37.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (161c45f) 741 561 75.71%
Head commit (d8df60c) 380 (-361) 324 (-237) 85.26% (+9.55%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#496) 8 3 37.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link
Contributor

@DMarinhoCodacy DMarinhoCodacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lolgab lolgab merged commit 9cc735f into master Mar 25, 2024
18 checks passed
@lolgab lolgab deleted the replace-scalaj-sttp branch March 25, 2024 14:30
@lolgab lolgab restored the replace-scalaj-sttp branch March 25, 2024 15:29
@lolgab lolgab deleted the replace-scalaj-sttp branch March 25, 2024 15:29
lolgab added a commit that referenced this pull request Mar 25, 2024
lolgab added a commit that referenced this pull request Mar 25, 2024
lolgab added a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants