Add more failing tests to fix

Author: lorisleiva

packages/visitors/test/unwrapDefinedTypesVisitor.test.ts

@@ -72,3 +72,42 @@ test('it follows linked nodes using the correct paths', () => {
         definedTypeNode({ name: 'typeA', type: numberTypeNode('u64') }),
     );
 });
+
+test('it does not unwrap types from the wrong programs', () => {
+    // Given a program node with a defined type used in another type.
+    const programA = programNode({
+        definedTypes: [
+            definedTypeNode({ name: 'myType', type: numberTypeNode('u8') }),
+            definedTypeNode({ name: 'myCopyType', type: definedTypeLinkNode('myType') }),
+        ],
+        name: 'programA',
+        publicKey: '1111',
+    });
+
+    // And another program with a defined type sharing the same name.
+    const programB = programNode({
+        definedTypes: [
+            definedTypeNode({ name: 'myType', type: numberTypeNode('u16') }),
+            definedTypeNode({ name: 'myCopyType', type: definedTypeLinkNode('myType') }),
+        ],
+        name: 'programB',
+        publicKey: '2222',
+    });
+
+    // When we unwrap the defined type from programA.
+    const node = rootNode(programA, [programB]);
+    const result = visit(node, unwrapDefinedTypesVisitor(['myType']));
+
+    // Then we expect programA to have been modified but not programB.
+    assertIsNode(result, 'rootNode');
+    expect(result).toStrictEqual(
+        rootNode(
+            programNode({
+                definedTypes: [definedTypeNode({ name: 'myCopyType', type: numberTypeNode('u8') })],
+                name: 'programA',
+                publicKey: '1111',
+            }),
+            [programB],
+        ),
+    );
+});

packages/visitors/test/unwrapInstructionArgsDefinedTypesVisitor.test.ts

@@ -38,7 +38,6 @@ test('it unwraps defined type link nodes used as instruction arguments', () => {
             ],
             name: 'MyProgram',
             publicKey: '1111',
-            version: '1.2.3',
         }),
     );
 
@@ -70,7 +69,6 @@ test('it unwraps defined type link nodes used as instruction arguments', () => {
                 ],
                 name: 'MyProgram',
                 publicKey: '1111',
-                version: '1.2.3',
             }),
         ),
     );
@@ -95,7 +93,6 @@ test('it does not unwrap defined type link nodes that are used in more than one
             ],
             name: 'MyProgram',
             publicKey: '1111',
-            version: '1.2.3',
         }),
     );
 
@@ -129,7 +126,6 @@ test('it only unwraps defined type link nodes if they are direct instruction arg
             ],
             name: 'MyProgram',
             publicKey: '1111',
-            version: '1.2.3',
         }),
     );
 
@@ -152,7 +148,6 @@ test('it does not unwrap defined type link nodes from other programs', () => {
         ],
         name: 'programA',
         publicKey: '1111',
-        version: '1.2.3',
     });
 
     // And another program with a defined type sharing the same name.
@@ -163,7 +158,6 @@ test('it does not unwrap defined type link nodes from other programs', () => {
         ],
         name: 'programB',
         publicKey: '2222',
-        version: '1.2.3',
     });
 
     // When we unwrap defined type link nodes for instruction arguments for both of them.
@@ -182,7 +176,6 @@ test('it does not unwrap defined type link nodes from other programs', () => {
                 ],
                 name: 'programA',
                 publicKey: '1111',
-                version: '1.2.3',
             }),
             [programB],
         ),